Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[multikueue] Add garbage collector. #1643

Merged
merged 12 commits into from Feb 5, 2024
Merged

[multikueue] Add garbage collector. #1643

merged 12 commits into from Feb 5, 2024

Conversation

trasc
Copy link
Contributor

@trasc trasc commented Jan 25, 2024 •
edited by k8s-ci-robot

What type of PR is this?

/kind feature

What this PR does / why we need it:

Add MultiKueue garbage collection.
A component that periodically, based on kueueManagerConfig.MultiKueue.GCTimeout , lists the remote objects created on the remote MultiKueueClusters , having the label kueue.x-k8s.io/multikueue-origin set to config.multiKueue,origin , and delete those who no longer have a local counterpart.

Which issue(s) this PR fixes:

Relates to #693

Special notes for your reviewer:

Does this PR introduce a user-facing change?

MultiKueue: Add garbage collection of deleted Workloads.

@k8s-ci-robot
Copy link
Contributor

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. kind/feature Categorizes issue or PR as related to a new feature. labels Jan 25, 2024
@netlify Netlify
Copy link

netlify bot commented Jan 25, 2024 •
edited

✅ Deploy Preview for kubernetes-sigs-kueue canceled.

Name Link
🔨 Latest commit ebe1e32
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-sigs-kueue/deploys/65c1159dacc5850008f19fbc

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jan 25, 2024
@k8s-ci-robot k8s-ci-robot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Jan 25, 2024
@trasc
Copy link
Contributor Author

trasc commented Jan 25, 2024

/test all

@trasc trasc force-pushed the multikueue-gc branch 3 times, most recently from 138cd50 to c42fd3f Compare January 26, 2024 12:10
@trasc trasc changed the title multikueue] Add garbage collector. [multikueue] Add garbage collector. Jan 26, 2024
@trasc
Copy link
Contributor Author

trasc commented Jan 26, 2024

/hold
for #1631

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 26, 2024
@trasc trasc marked this pull request as ready for review January 26, 2024 12:11
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jan 26, 2024
@k8s-ci-robot k8s-ci-robot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Jan 29, 2024
@trasc
Copy link
Contributor Author

trasc commented Jan 29, 2024

/unhold

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 29, 2024
@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 2, 2024
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 254effaa8d7d6cc18541fa549154eb106d19e808

@mimowo
Copy link
Contributor

mimowo commented Feb 2, 2024

BTW, I don't think this warrants a separate release note, because this is a non-released feature yet. I think one generic release note saying "Support for MultiKueue at Alpha level" (from one PR) would be enough for users, but this is a nit.

@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 2, 2024
tenzen-y
tenzen-y reviewed Feb 2, 2024
View reviewed changes
Copy link
Member

@tenzen-y tenzen-y left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have not yet reviewed integration tests.

apis/config/v1beta1/configuration_types.go Outdated Show resolved Hide resolved
apis/config/v1beta1/configuration_types.go Outdated Show resolved Hide resolved
apis/config/v1beta1/defaults.go Show resolved Hide resolved
apis/config/v1beta1/configuration_types.go Outdated Show resolved Hide resolved
apis/config/v1beta1/defaults_test.go Show resolved Hide resolved
pkg/controller/admissionchecks/multikueue/multikueuecluster.go Outdated Show resolved Hide resolved
pkg/controller/admissionchecks/multikueue/multikueuecluster.go Outdated Show resolved Hide resolved
pkg/controller/admissionchecks/multikueue/multikueuecluster.go Show resolved Hide resolved
pkg/controller/admissionchecks/multikueue/multikueuecluster.go Show resolved Hide resolved
pkg/controller/admissionchecks/multikueue/multikueuecluster_test.go Show resolved Hide resolved
alculquicondor
alculquicondor reviewed Feb 5, 2024
View reviewed changes
cmd/kueue/main.go Outdated Show resolved Hide resolved
pkg/controller/admissionchecks/multikueue/multikueuecluster.go Outdated Show resolved Hide resolved
pkg/controller/admissionchecks/multikueue/multikueuecluster.go
}
}
}
wlLog.V(5).Info("MultiKueueGC deleting remote workload")
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this can be inside an "else", as deleting the owner would cascade the deletion of the workload without an additional API call.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I prefer to keep it as is, I find it easier to follow.

pkg/controller/admissionchecks/multikueue/multikueuecluster.go Outdated Show resolved Hide resolved
@alculquicondor
Copy link
Contributor

/approve
/hold
for comments

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Feb 5, 2024
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: alculquicondor, trasc

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 5, 2024
@alculquicondor
Copy link
Contributor

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 5, 2024
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 6121d5ba125ce1f6e953d6aaf37b35fe10980ea2

@alculquicondor
Copy link
Contributor

/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Feb 5, 2024
@k8s-ci-robot k8s-ci-robot merged commit 2326377 into kubernetes-sigs:main Feb 5, 2024
14 checks passed
@k8s-ci-robot k8s-ci-robot added this to the v0.6 milestone Feb 5, 2024
@trasc trasc deleted the multikueue-gc branch February 6, 2024 04:51
@tenzen-y
Copy link
Member

/kind api-change

@k8s-ci-robot k8s-ci-robot added the kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API label Feb 12, 2024
@alculquicondor
Copy link
Contributor

/release-note-edit

MultiKueue: Add garbage collection of deleted Workloads.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alculquicondor alculquicondor alculquicondor left review comments

@tenzen-y tenzen-y tenzen-y left review comments

@denkensk denkensk Awaiting requested review from denkensk

@mimowo mimowo Awaiting requested review from mimowo

Assignees

@alculquicondor alculquicondor

@mimowo mimowo

@tenzen-y tenzen-y

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API kind/feature Categorizes issue or PR as related to a new feature. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Milestone
v0.6
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@trasc @k8s-ci-robot @alculquicondor @mimowo @tenzen-y