Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Automated cherry pick of #1679: Make sure pending workloads are removed from the cache #1687

Merged
merged 1 commit into from Feb 6, 2024
Merged

Automated cherry pick of #1679: Make sure pending workloads are removed from the cache #1687

merged 1 commit into from Feb 6, 2024

Conversation

astefanutti
Copy link
Member

@astefanutti astefanutti commented Feb 5, 2024 •
edited

Cherry pick of #1679 on release-0.5.
#1679: Make sure pending workloads are removed from the cache
For details on the cherry pick process, see the cherry pick requests page.

Remove deleted pending workloads from the cache

@k8s-ci-robot k8s-ci-robot added this to the v0.5 milestone Feb 5, 2024
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Feb 5, 2024
@netlify Netlify
Copy link

netlify bot commented Feb 5, 2024 •
edited

✅ Deploy Preview for kubernetes-sigs-kueue canceled.

Name Link
🔨 Latest commit 766be82
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-sigs-kueue/deploys/65c215d43671c30008bb1200

@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Feb 5, 2024
@k8s-ci-robot
Copy link
Contributor

Hi @astefanutti. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Feb 5, 2024
@astefanutti astefanutti force-pushed the automated-cherry-pick-of-#1679-origin-release-0.5 branch from 0dd3645 to c2c855d Compare February 5, 2024 18:42
@k8s-ci-robot k8s-ci-robot added the release-note Denotes a PR that will be considered when it comes time to generate release notes. label Feb 5, 2024
@astefanutti astefanutti mentioned this pull request Feb 5, 2024
Closed
@tenzen-y
Copy link
Member

tenzen-y commented Feb 5, 2024

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Feb 5, 2024
@alculquicondor
Copy link
Contributor

/retest

@alculquicondor
Copy link
Contributor

Did you forget to change something?

@astefanutti astefanutti force-pushed the automated-cherry-pick-of-#1679-origin-release-0.5 branch 2 times, most recently from 025901b to d315056 Compare February 5, 2024 19:49
@astefanutti
Copy link
Member Author

Did you forget to change something?

One missing ignore cmp.Option :\ It should be good now.

@astefanutti astefanutti force-pushed the automated-cherry-pick-of-#1679-origin-release-0.5 branch from d315056 to 766be82 Compare February 6, 2024 11:19
@alculquicondor
Copy link
Contributor

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 6, 2024
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 00bf1b2c49018589253134301c23a9bf9a21c2b1

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: alculquicondor, astefanutti

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 6, 2024
@k8s-ci-robot k8s-ci-robot merged commit 5a6a389 into kubernetes-sigs:release-0.5 Feb 6, 2024
15 checks passed
@alculquicondor
Copy link
Contributor

/kind bug

@k8s-ci-robot k8s-ci-robot added the kind/bug Categorizes issue or PR as related to a bug. label Feb 9, 2024
@astefanutti astefanutti deleted the automated-cherry-pick-of-#1679-origin-release-0.5 branch February 9, 2024 16:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alculquicondor alculquicondor alculquicondor left review comments

@denkensk denkensk Awaiting requested review from denkensk

@trasc trasc Awaiting requested review from trasc

Assignees

@alculquicondor alculquicondor

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
v0.5
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@astefanutti @k8s-ci-robot @tenzen-y @alculquicondor