Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release-0.6][pods] Finalize the replaced pods #1801

Conversation

trasc
Copy link
Contributor

@trasc trasc commented Mar 5, 2024

What type of PR is this?

/kind feature

What this PR does / why we need it:

Manual cherry-pick of #1766

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

The automatic cherry-pick was blocked by a conflict on deduplication of corev1 import in e2e tests. Solved, no impact on the main logic.

Does this PR introduce a user-facing change?

The Failed pods in a pod-group are finalized once a replacement pods are created.

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/feature Categorizes issue or PR as related to a new feature. labels Mar 5, 2024
Copy link

linux-foundation-easycla bot commented Mar 5, 2024

CLA Signed

@k8s-ci-robot k8s-ci-robot added cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Mar 5, 2024
Copy link

netlify bot commented Mar 5, 2024

Deploy Preview for kubernetes-sigs-kueue canceled.

Name Link
🔨 Latest commit 6f26bf8
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-sigs-kueue/deploys/65e6dbb2bd4e6e0008a670a1

@trasc trasc changed the base branch from main to release-0.6 March 5, 2024 07:04
@k8s-ci-robot k8s-ci-robot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Mar 5, 2024
@trasc
Copy link
Contributor Author

trasc commented Mar 5, 2024

/retest

@trasc trasc force-pushed the rel06-pods-finalize-failed-on-replacement branch 2 times, most recently from 37bf10f to c850961 Compare March 5, 2024 07:15
@tenzen-y
Copy link
Member

tenzen-y commented Mar 5, 2024

/check-cla

@trasc I guess that you need to sign commit with git commit -s.

Signed-off-by: Traian Schiau <traian_schiau@epam.com>
@trasc trasc force-pushed the rel06-pods-finalize-failed-on-replacement branch from c850961 to 6f26bf8 Compare March 5, 2024 08:45
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. and removed cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels Mar 5, 2024
@tenzen-y
Copy link
Member

tenzen-y commented Mar 5, 2024

Alright, CLA has been passed.

Copy link
Member

@tenzen-y tenzen-y left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added lgtm "Looks good to me", indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Mar 5, 2024
@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Mar 5, 2024

@trasc: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-kueue-test-e2e-main-1-27 37bf10f link true /test pull-kueue-test-e2e-main-1-27
pull-kueue-test-e2e-main-1-28 37bf10f link true /test pull-kueue-test-e2e-main-1-28
pull-kueue-test-unit-main 37bf10f link true /test pull-kueue-test-unit-main
pull-kueue-test-e2e-main-1-26 37bf10f link true /test pull-kueue-test-e2e-main-1-26
pull-kueue-verify-main 37bf10f link true /test pull-kueue-verify-main
pull-kueue-build-image-main 37bf10f link true /test pull-kueue-build-image-main
pull-kueue-test-integration-main 37bf10f link true /test pull-kueue-test-integration-main
pull-kueue-test-e2e-main-1-29 37bf10f link true /test pull-kueue-test-e2e-main-1-29

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@tenzen-y
Copy link
Member

tenzen-y commented Mar 5, 2024

/approve cancel
/lgtm cancel

It seems that CONFLICTS still occur.

@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 5, 2024
@k8s-ci-robot k8s-ci-robot removed the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 5, 2024
Copy link
Member

@tenzen-y tenzen-y left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 5, 2024
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: d1e1dc8cab88dae91c095112b09ce9a3b3722bae

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: tenzen-y, trasc

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 5, 2024
@k8s-ci-robot k8s-ci-robot merged commit 08ba598 into kubernetes-sigs:release-0.6 Mar 5, 2024
14 checks passed
@k8s-ci-robot k8s-ci-robot added this to the v0.6 milestone Mar 5, 2024
@trasc trasc deleted the rel06-pods-finalize-failed-on-replacement branch March 5, 2024 10:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/feature Categorizes issue or PR as related to a new feature. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants