Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Passing parameters to ProvisioningRequest from annotations #1869

Merged
merged 1 commit into from Mar 26, 2024
Merged

Passing parameters to ProvisioningRequest from annotations #1869

merged 1 commit into from Mar 26, 2024

Conversation

PBundyra
Copy link
Contributor

What type of PR is this?

/kind feature
/kind api-change

What this PR does / why we need it:

This implements changes introduced in #1788 and #1793

Which issue(s) this PR fixes:

Fixes #1788

Special notes for your reviewer:

I've done manual e2e testing

Does this PR introduce a user-facing change?

User can now pass parameters to ProvisioningRequest using job's annotations

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/feature Categorizes issue or PR as related to a new feature. kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API labels Mar 20, 2024
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Mar 20, 2024
@netlify Netlify
Copy link

netlify bot commented Mar 20, 2024 •
edited

✅ Deploy Preview for kubernetes-sigs-kueue canceled.

Name Link
🔨 Latest commit 2b8b01c
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-sigs-kueue/deploys/6602ac62474abf0008679552

@PBundyra PBundyra force-pushed the prov-req-annotations branch 3 times, most recently from 9072875 to 072ff25 Compare March 20, 2024 14:11
@PBundyra PBundyra force-pushed the prov-req-annotations branch 3 times, most recently from 9b5ccef to b2c28ea Compare March 21, 2024 09:30
@PBundyra
Copy link
Contributor Author

/assign @yaroslava-serdiuk

@alculquicondor
Copy link
Contributor

Please include integration tests for jobs and pods

@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Mar 22, 2024
@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Mar 22, 2024
@PBundyra
Copy link
Contributor Author

/retest

1 similar comment
@PBundyra
Copy link
Contributor Author

/retest

@PBundyra
Copy link
Contributor Author

I'll reverse changes regarding setup-envtest version when #1883 is merged

gabesaba
gabesaba approved these changes Mar 22, 2024
View reviewed changes
Copy link
Contributor

@gabesaba gabesaba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

other than a few nitpicks, looks good

/lgtm

pkg/controller/admissionchecks/provisioning/controller.go Show resolved Hide resolved
pkg/controller/admissionchecks/provisioning/controller.go Outdated Show resolved Hide resolved
pkg/controller/constants/constants.go Show resolved Hide resolved
pkg/controller/jobframework/reconciler.go Outdated Show resolved Hide resolved
pkg/controller/jobframework/reconciler.go Outdated Show resolved Hide resolved
pkg/controller/admissionchecks/provisioning/controller.go Outdated Show resolved Hide resolved
@k8s-ci-robot
Copy link
Contributor

@gabesaba: changing LGTM is restricted to collaborators

In response to this:

other than a few nitpicks, looks good

/lgtm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@alculquicondor
Copy link
Contributor

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: alculquicondor, gabesaba, PBundyra

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 22, 2024
mimowo
mimowo reviewed Mar 25, 2024
View reviewed changes
Copy link
Contributor

@mimowo mimowo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just a naming nit

pkg/util/testing/wrappers.go Outdated Show resolved Hide resolved
pkg/util/testingjobs/jobset/wrappers.go Outdated Show resolved Hide resolved
pkg/util/testingjobs/mxjob/wrappers.go Outdated Show resolved Hide resolved
@mimowo
Copy link
Contributor

mimowo commented Mar 26, 2024

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 26, 2024
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: b4492ec0256b05671735ff07ea7339d1e273bc73

@k8s-ci-robot k8s-ci-robot merged commit 2c16bbb into kubernetes-sigs:main Mar 26, 2024
13 checks passed
@k8s-ci-robot k8s-ci-robot added this to the v0.7 milestone Mar 26, 2024
vsoch pushed a commit to researchapps/kueue that referenced this pull request Apr 18, 2024
@PBundyra @vsoch
Passing parameters to ProvisioningRequest from annotations (kubernete…
6c9be04 
…s-sigs#1869)
@PBundyra PBundyra deleted the prov-req-annotations branch April 26, 2024 09:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alculquicondor alculquicondor alculquicondor left review comments

@mimowo mimowo mimowo left review comments

@gabesaba gabesaba gabesaba approved these changes

@denkensk denkensk Awaiting requested review from denkensk

Assignees

@mimowo mimowo

@yaroslava-serdiuk yaroslava-serdiuk

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API kind/feature Categorizes issue or PR as related to a new feature. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
v0.7
Development

Successfully merging this pull request may close these issues.

A mechanism to pass parameters to ProvisioningRequest
6 participants
@PBundyra @alculquicondor @k8s-ci-robot @mimowo @gabesaba @yaroslava-serdiuk