Non-admitted workloads with QuotaReserved condition are shown as Admitted by kubectl

[vladikkuzn]

What type of PR is this?

/kind cleanup

What this PR does / why we need it:

• Renames "Admitted by" to "Reserving in" printed column of kubectl get workload
• Adds "Admitted" printed column to kubectl get workload

Which issue(s) this PR fixes:

Fixes #1790

Special notes for your reviewer:

Does this PR introduce a user-facing change?

Improve the kubectl output for workloads using admission checks.

[k8s-ci-robot]

Hi @vladikkuzn. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[netlify]

✅ Deploy Preview for kubernetes-sigs-kueue ready!

Name	Link
🔨 Latest commit	49b10ae
🔍 Latest deploy log	https://app.netlify.com/sites/kubernetes-sigs-kueue/deploys/6620e0f8193ef30008d97ad4
😎 Deploy Preview	https://deploy-preview-1991--kubernetes-sigs-kueue.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

---

To edit notification comments on pull requests, go to your Netlify site configuration.

[trasc]

/assign
/ok-to-test

[vladikkuzn]

That's how it looks:

And without wide option:

It's not possible to make it only True/False because it's a enum of 3 values: True/False/Unknown. Most projects output it that way

[mimowo]

Overall lgtm.

[mimowo]

/release-note-edit Improve the kubectl output for workloads using admission checks

[mimowo]

/release-note-edit```
Improve the kubectl output for workloads using admission checks

[mimowo]

/release-note-edit ```
Improve the kubectl output for workloads using admission checks

[mimowo]

Ok, not sure what I do wrong :) Please update the release note manually

[vladikkuzn]

/release-note-edit

Improve the kubectl output for workloads using admission checks

[k8s-ci-robot]

@vladikkuzn: You must be an org member to edit the release note.

In response to this:

/release-note-edit

Improve the kubectl output for workloads using admission checks

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[mimowo]

Yay, this worked:

[vladikkuzn]

Made updates to the docs, thanks for notifying @tenzen-y

[alculquicondor]

Thanks!

/lgtm
/approve

[k8s-ci-robot]

LGTM label has been added.

Git tree hash: c4884685884ab7ac35668a19ce6c528a610d8386

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: alculquicondor, vladikkuzn

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [alculquicondor]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[alculquicondor]

/cherry-pick release-0.6

[k8s-infra-cherrypick-robot]

@alculquicondor: once the present PR merges, I will cherry-pick it on top of release-0.6 in a new PR and assign it to you.

In response to this:

/cherry-pick release-0.6

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[k8s-infra-cherrypick-robot]

@alculquicondor: #1991 failed to apply on top of branch "release-0.6":

Applying: * Rename "Admitted by" to "Reserving in" printed column * Add "Admitted" printed column
Applying: * Output Admitted column without -wide
Applying: * Remove priority=0 as it's default
Applying: * Documentation update * Rename "Reserving in" to "Reserved in"
Using index info to reconstruct a base tree...
M	apis/kueue/v1beta1/workload_types.go
M	charts/kueue/templates/crd/kueue.x-k8s.io_workloads.yaml
M	config/components/crd/bases/kueue.x-k8s.io_workloads.yaml
A	site/content/en/docs/tasks/run/jobs.md
A	site/content/en/docs/tasks/troubleshooting/troubleshooting_jobs.md
Falling back to patching base and 3-way merge...
CONFLICT (modify/delete): site/content/en/docs/tasks/troubleshooting/troubleshooting_jobs.md deleted in HEAD and modified in * Documentation update * Rename "Reserving in" to "Reserved in". Version * Documentation update * Rename "Reserving in" to "Reserved in" of site/content/en/docs/tasks/troubleshooting/troubleshooting_jobs.md left in tree.
Auto-merging site/content/en/docs/tasks/run_jobs.md
Auto-merging config/components/crd/bases/kueue.x-k8s.io_workloads.yaml
Auto-merging charts/kueue/templates/crd/kueue.x-k8s.io_workloads.yaml
Auto-merging apis/kueue/v1beta1/workload_types.go
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
Patch failed at 0004 * Documentation update * Rename "Reserving in" to "Reserved in"
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".

In response to this:

/cherry-pick release-0.6

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[alculquicondor]

@tenzen-y what's your sentiment? should we attempt a manual cherry-pick?

[tenzen-y]

@tenzen-y what's your sentiment? should we attempt a manual cherry-pick?

I think that cherry-picking would be worth it.
Actually, this is a bug since the Admitted status is shown based on the QuotaReserved without this commit.

[alculquicondor]

@vladikkuzn could you produce a manual cherry-pick?
You can use ./hack/cherry_pick-pull.sh release-0.6 1991 to get started.

[alculquicondor]

/remove-kind cleanup
/kind feature