Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[kueuectl] Create Local Queue #2027

Merged
merged 2 commits into from May 3, 2024
Merged

[kueuectl] Create Local Queue #2027

merged 2 commits into from May 3, 2024

Conversation

mbobrovskyi
Copy link
Contributor

@mbobrovskyi mbobrovskyi commented Apr 22, 2024 •
edited

What type of PR is this?

/kind feature

What this PR does / why we need it:

  • Initialised command line tool.
  • Added command to create local queue.

Which issue(s) this PR fixes:

Special notes for your reviewer:

Does this PR introduce a user-facing change?

Add kubectl kueue plugin that allows to create LocalQueues without writing yamls.

@k8s-ci-robot k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. kind/feature Categorizes issue or PR as related to a new feature. do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Apr 22, 2024
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Apr 22, 2024
@k8s-ci-robot
Copy link
Contributor

Hi @mbobrovskyi. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Apr 22, 2024
@netlify Netlify
Copy link

netlify bot commented Apr 22, 2024 •
edited

✅ Deploy Preview for kubernetes-sigs-kueue canceled.

Name Link
🔨 Latest commit 04cbcab
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-sigs-kueue/deploys/6634e072bcb4a500080ccc88

@trasc
Copy link
Contributor

trasc commented Apr 22, 2024

/ok-to-test
/assign

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Apr 22, 2024
@mbobrovskyi
Copy link
Contributor Author

/ok-to-test

@trasc
Copy link
Contributor

trasc commented Apr 23, 2024

/test all

@trasc
Copy link
Contributor

trasc commented Apr 23, 2024

/cc @IrvingMg
/cc @vladikkuzn

@k8s-ci-robot
Copy link
Contributor

@trasc: GitHub didn't allow me to request PR reviews from the following users: IrvingMg, vladikkuzn.

Note that only kubernetes-sigs members and repo collaborators can review this PR, and authors cannot review their own PRs.

In response to this:

/cc @IrvingMg
/cc @vladikkuzn

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

trasc
trasc reviewed Apr 23, 2024
View reviewed changes
hack/multiplatform-build.sh Outdated Show resolved Hide resolved
cmd/kueuectl/docs/README.md Outdated Show resolved Hide resolved
cmd/kueuectl/cmd/create/create_localqueue_test.go Outdated Show resolved Hide resolved
cmd/kueuectl/cmd/create/create_localqueue.go Outdated Show resolved Hide resolved
cmd/kueuectl/cmd/create/create_localqueue.go Outdated Show resolved Hide resolved
test/integration/kueuectl/create_test.go Outdated Show resolved Hide resolved
@k8s-ci-robot k8s-ci-robot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Apr 23, 2024
@mbobrovskyi
Copy link
Contributor Author

/ok-to-test

trasc
trasc reviewed Apr 24, 2024
View reviewed changes
Copy link
Contributor

@trasc trasc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@vladikkuzn @IrvingMg please have a look as well , for now we mainly want to have a structure established.

Without going to too much details it looks good to me.

site/content/en/docs/kueuectl/_index.md Outdated Show resolved Hide resolved
site/content/en/docs/kueuectl/_index.md Outdated Show resolved Hide resolved
@vladikkuzn
Copy link
Contributor

Overall looks good, except that one thing with cmd inside cmd

@vladikkuzn vladikkuzn mentioned this pull request Apr 26, 2024
Closed
11 tasks
@trasc
Copy link
Contributor

trasc commented Apr 26, 2024

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 26, 2024
@alculquicondor
Copy link
Contributor

/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label May 1, 2024
alculquicondor
alculquicondor reviewed May 1, 2024
View reviewed changes
Makefile Outdated Show resolved Hide resolved
@alculquicondor
Copy link
Contributor

/approve

@tenzen-y anything to add?
For now, we are not including the binary in the release artifacts, but we can continue the development in separate PRs.

tenzen-y
tenzen-y reviewed May 2, 2024
View reviewed changes
cmd/kueuectl/app/create/create_localqueue.go

util.AddDryRunFlag(cmd)
cmd.Flags().StringVarP(&o.UserSpecifiedClusterQueue, "clusterqueue", "c", "",
"The cluster queue name which will be associated with the local queue (required).")
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No need to specify namespace since the clusterQueue is the cluster scoped resource.

tenzen-y
tenzen-y reviewed May 2, 2024
View reviewed changes
Copy link
Member

@tenzen-y tenzen-y left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work! Thank you!
/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 2, 2024
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 5367c21394de5b237545f4be4e8e054707fcd75b

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: alculquicondor, mbobrovskyi, tenzen-y

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [alculquicondor,tenzen-y]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@mbobrovskyi
Copy link
Contributor Author

@alculquicondor @tenzen-y can we merge it to master?

@alculquicondor
Copy link
Contributor

Not sure why this is stuck for 12h

/retest

@alculquicondor
Copy link
Contributor

https://prow.k8s.io/view/gs/kubernetes-jenkins/pr-logs/pull/kubernetes-sigs_kueue/2027/pull-kueue-test-integration-main/1785945235516297216

The job is actually stuck 🤔

image

The tests themselves seem to have finished, but something about the post-processing is stuck. Maybe it's related to #2097

I'm not sure how to get it unstuck. Can you try just squashing all the commits?

@mbobrovskyi mbobrovskyi force-pushed the feature/kueuectl-localqueue branch from ae9cad0 to 4bdcdcf Compare May 2, 2024 20:58
@mbobrovskyi
Copy link
Contributor Author

/test pull-kueue-test-integration-main

@mbobrovskyi mbobrovskyi force-pushed the feature/kueuectl-localqueue branch from 4bdcdcf to 87c54d6 Compare May 3, 2024 10:11
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 3, 2024
@k8s-ci-robot k8s-ci-robot requested a review from tenzen-y May 3, 2024 10:11
@mbobrovskyi
Copy link
Contributor Author

/test pull-kueue-test-integration-main

@alculquicondor
Copy link
Contributor

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 3, 2024
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 0eafaff0c4226b3f6199a6c453496b7cac2c254c

@k8s-ci-robot k8s-ci-robot merged commit 0ef74d4 into kubernetes-sigs:main May 3, 2024
15 checks passed
@k8s-ci-robot k8s-ci-robot added this to the v0.7 milestone May 3, 2024
@mbobrovskyi mbobrovskyi deleted the feature/kueuectl-localqueue branch May 3, 2024 20:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alculquicondor alculquicondor alculquicondor left review comments

@mwielgus mwielgus mwielgus left review comments

@kerthcet kerthcet kerthcet left review comments

@IrvingMg IrvingMg IrvingMg left review comments

@vladikkuzn vladikkuzn vladikkuzn left review comments

@mimowo mimowo Awaiting requested review from mimowo

@trasc trasc Awaiting requested review from trasc

@tenzen-y tenzen-y Awaiting requested review from tenzen-y

Assignees

@alculquicondor alculquicondor

@tenzen-y tenzen-y

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/feature Categorizes issue or PR as related to a new feature. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Milestone
v0.7
Development

Successfully merging this pull request may close these issues.

None yet
9 participants
@mbobrovskyi @k8s-ci-robot @trasc @vladikkuzn @alculquicondor @tenzen-y @mwielgus @kerthcet @IrvingMg