Move the eviction by inactivation mechanism from the jobframework reconciler to the workload controller #2131
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…onciler to the workload controller Signed-off-by: Yuki Iwai <yuki.iwai.tz@gmail.com>
k8s-ci-robot
added
release-note
k8s-ci-robot
added
approved
✅ Deploy Preview for kubernetes-sigs-kueue ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: alculquicondor, tenzen-y The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
LGTM label has been added. Git tree hash: c2975e1caa8b7422d3b483635ea7d92b6a66403e
|
This was referenced May 7, 2024
mbobrovskyi
pushed a commit
to epam/kubernetes-kueue
that referenced
this pull request
May 19, 2024
…onciler to the workload controller (kubernetes-sigs#2131) Signed-off-by: Yuki Iwai <yuki.iwai.tz@gmail.com> (cherry picked from commit 1d5b682)
mbobrovskyi
pushed a commit
to epam/kubernetes-kueue
that referenced
this pull request
May 20, 2024
…onciler to the workload controller (kubernetes-sigs#2131) Signed-off-by: Yuki Iwai <yuki.iwai.tz@gmail.com> (cherry picked from commit 1d5b682)
k8s-ci-robot
pushed a commit
that referenced
this pull request
May 20, 2024
…hanism from the (#2229) * Move the eviction by inactivation mechanism from the jobframework reconciler to the workload controller Signed-off-by: Yuki Iwai <yuki.iwai.tz@gmail.com> * Should update Evicted condition only when the Workload have not already got Eviction (#2172) Signed-off-by: Yuki Iwai <yuki.iwai.tz@gmail.com> (cherry picked from commit 2b90363) --------- Signed-off-by: Yuki Iwai <yuki.iwai.tz@gmail.com> Co-authored-by: Yuki Iwai <yuki.iwai.tz@gmail.com>
|
/release-note-edit Not user-facing. |
k8s-ci-robot
added
release-note-none
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind cleanup
What this PR does / why we need it:
I moved the eviction by inactivation mechanism to the workload controller so that users can avoid re-implementing the same mechanism in the user's integrations controller without the jobframework reconciler.
Which issue(s) this PR fixes:
Fixes #1841
Special notes for your reviewer:
Does this PR introduce a user-facing change?