Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable goimports #229

Merged
merged 1 commit into from Apr 29, 2022
Merged

Enable goimports #229

merged 1 commit into from Apr 29, 2022

Conversation

shuheiktgw
Copy link
Contributor

What type of PR is this?

/kind cleanup

What this PR does / why we need it:

Enable goimports and automatically detects unorganized imports

Which issue(s) this PR fixes:

Fixes #228 (comment)

Special notes for your reviewer:

@k8s-ci-robot k8s-ci-robot added kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Apr 23, 2022
@k8s-ci-robot
Copy link
Contributor

Hi @shuheiktgw. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Apr 23, 2022
@k8s-ci-robot k8s-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Apr 23, 2022
shuheiktgw
shuheiktgw commented Apr 23, 2022
View reviewed changes
.golangci.yaml Outdated
- structcheck
- typecheck
- unused
- varcheck
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These linters are enabled by default except for goimports, so the actual change is simply enabling it

@denkensk
Copy link
Member

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Apr 24, 2022
alculquicondor
alculquicondor reviewed Apr 25, 2022
View reviewed changes
.golangci.yaml Outdated

# Settings for enabling and disabling linters
linters:
disable-all: true
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why not just enable goimports instead of disabling everything beforehand?

pkg/controller/core/clusterqueue_controller.go Outdated
@@ -20,7 +20,6 @@ import (
"context"

"github.com/go-logr/logr"
"sigs.k8s.io/kueue/pkg/constants"

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove this empty line. let's not have 4 blocks of imports, just 3.

test/integration/controller/core/clusterqueue_controller_test.go Outdated
@@ -19,11 +19,12 @@ package core
import (
"github.com/onsi/ginkgo/v2"
"github.com/onsi/gomega"

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove this line

test/integration/controller/core/queue_controller_test.go Outdated
@@ -19,10 +19,11 @@ package core
import (
"github.com/onsi/ginkgo/v2"
"github.com/onsi/gomega"

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove

test/integration/controller/core/workload_controller_test.go Outdated
@@ -21,10 +21,11 @@ import (

"github.com/onsi/ginkgo/v2"
"github.com/onsi/gomega"

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove

@shuheiktgw
Copy link
Contributor Author

@alculquicondor I've fixed the PR so would you take a look at it again? 🙏

alculquicondor
alculquicondor reviewed Apr 26, 2022
View reviewed changes
Copy link
Contributor

@alculquicondor alculquicondor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

Can you squash?

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 26, 2022
@shuheiktgw
Copy link
Contributor Author

@alculquicondor Thank you for your review! I've squashed the commits so would you check the PR again? 🙂

alculquicondor
alculquicondor approved these changes Apr 29, 2022
View reviewed changes
Copy link
Contributor

@alculquicondor alculquicondor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: alculquicondor, shuheiktgw

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 29, 2022
@alculquicondor
Copy link
Contributor

Either you missed a file or there was a new violation.

@alculquicondor alculquicondor mentioned this pull request Apr 29, 2022
Merged
@alculquicondor
Copy link
Contributor

/retest

@k8s-ci-robot k8s-ci-robot merged commit b179f0d into kubernetes-sigs:main Apr 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alculquicondor alculquicondor alculquicondor approved these changes

@ArangoGutierrez ArangoGutierrez Awaiting requested review from ArangoGutierrez

@denkensk denkensk Awaiting requested review from denkensk

Assignees

@alculquicondor alculquicondor

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@shuheiktgw @k8s-ci-robot @denkensk @alculquicondor