Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release-0.7] [fix] update assignedFlavorIdx at the beginning of loop #2440

Conversation

k8s-infra-cherrypick-robot
Copy link

@k8s-infra-cherrypick-robot k8s-infra-cherrypick-robot commented Jun 19, 2024

This is an automated cherry-pick of #2407

/assign mimowo

Fix for the scenario when a workload doesn't match some resource flavors due to affinity or taints
could cause the workload to be continuously retried.

@k8s-ci-robot k8s-ci-robot added the release-note-none Denotes a PR that doesn't merit a release note. label Jun 19, 2024
@k8s-ci-robot k8s-ci-robot added this to the v0.7 milestone Jun 19, 2024
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jun 19, 2024
Copy link

netlify bot commented Jun 19, 2024

Deploy Preview for kubernetes-sigs-kueue ready!

Name Link
🔨 Latest commit ca90f0e
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-sigs-kueue/deploys/66729849e3f41b0008f80927
😎 Deploy Preview https://deploy-preview-2440--kubernetes-sigs-kueue.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@mimowo
Copy link
Contributor

mimowo commented Jun 19, 2024

/release-note-edit

Fix for the scenario when a workload which is not matching a certain resource flavor
is not checked against the consecutive resource flavors.

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. and removed release-note-none Denotes a PR that doesn't merit a release note. labels Jun 19, 2024
@mimowo
Copy link
Contributor

mimowo commented Jun 19, 2024

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 19, 2024
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: f7fbbe9f1fbec77a0ba5b119fd627aac23f5c0e8

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: k8s-infra-cherrypick-robot, mimowo

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 19, 2024
@k8s-ci-robot k8s-ci-robot merged commit 8950342 into kubernetes-sigs:release-0.7 Jun 19, 2024
15 of 16 checks passed
@alculquicondor
Copy link
Contributor

/release-note-edit

Fix for the scenario when a workload doesn't match some resource flavors due to affinity or taints
could cause the workload to be continuously retried.

@alculquicondor
Copy link
Contributor

/kind bug

@k8s-ci-robot k8s-ci-robot added the kind/bug Categorizes issue or PR as related to a bug. label Jul 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants