Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding junit.xml for unit/integration tests #423

Merged
merged 1 commit into from Nov 18, 2022
Merged

Adding junit.xml for unit/integration tests #423

merged 1 commit into from Nov 18, 2022

Conversation

kannon92
Copy link
Contributor

@kannon92 kannon92 commented Oct 21, 2022 •
edited

What type of PR is this?

Adding testgrid test reports.

I was told that adding junit report and saving those reports to artifacts. The testgrid project should upload these and display more detailed test report.

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #402

Special notes for your reviewer:

@k8s-ci-robot k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Oct 21, 2022
@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Oct 21, 2022
@k8s-ci-robot
Copy link
Contributor

Hi @kannon92. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Oct 21, 2022
@kerthcet
Copy link
Contributor

Is this still in progress?

@kerthcet
Copy link
Contributor

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Oct 27, 2022
@kannon92
Copy link
Contributor Author

Is this still in progress?

I’m trying to verify if this works with test grid. Thanks for kicking off a test. Once i verify it works, I’ll move it to ready

@kannon92 kannon92 changed the title WIP Adding report.xml for integration tests Adding junit.xml for unit/integration tests Oct 31, 2022
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Oct 31, 2022
@kannon92
Copy link
Contributor Author

This PR is ready. https://testgrid.k8s.io/sig-scheduling#pull-kueue-test-unit-main and https://testgrid.k8s.io/sig-scheduling#pull-kueue-test-integration-main show that we now have a dashboard for every test.

@kannon92 kannon92 mentioned this pull request Oct 31, 2022
Closed
BenTheElder
BenTheElder reviewed Oct 31, 2022
View reviewed changes
Makefile Outdated Show resolved Hide resolved
BenTheElder
BenTheElder reviewed Oct 31, 2022
View reviewed changes
Makefile Outdated Show resolved Hide resolved
@kannon92
Copy link
Contributor Author

kannon92 commented Nov 1, 2022

/retest

kerthcet
kerthcet reviewed Nov 2, 2022
View reviewed changes
Makefile Outdated Show resolved Hide resolved
@kerthcet
Copy link
Contributor

kerthcet commented Nov 2, 2022

The test grid looks good to me, so totally LGTM.

@kerthcet
Copy link
Contributor

kerthcet commented Nov 2, 2022

/kind feature

@k8s-ci-robot k8s-ci-robot added the kind/feature Categorizes issue or PR as related to a new feature. label Nov 2, 2022
@kerthcet
Copy link
Contributor

kerthcet commented Nov 3, 2022

Thanks @kannon92 , happy to see this change. I'll sent a lgtm then.
/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 3, 2022
alculquicondor
alculquicondor reviewed Nov 17, 2022
View reviewed changes
Makefile Outdated Show resolved Hide resolved
Makefile Outdated Show resolved Hide resolved
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 18, 2022
alculquicondor
alculquicondor reviewed Nov 18, 2022
View reviewed changes
Copy link
Contributor

@alculquicondor alculquicondor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just a nit.

Please squash

Makefile Outdated
@@ -11,7 +11,6 @@
# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
# See the License for the specific language governing permissions and
# limitations under the License.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

revert

@kannon92 kannon92 requested review from alculquicondor and removed request for ahg-g November 18, 2022 15:18
@alculquicondor
Copy link
Contributor

Awesome!

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 18, 2022
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: alculquicondor, kannon92

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 18, 2022
@k8s-ci-robot k8s-ci-robot merged commit c743a8d into kubernetes-sigs:main Nov 18, 2022
@kannon92 kannon92 mentioned this pull request Nov 29, 2022
Closed
9 tasks
@kannon92 kannon92 mentioned this pull request May 11, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BenTheElder BenTheElder BenTheElder left review comments

@kerthcet kerthcet kerthcet left review comments

@alculquicondor alculquicondor Awaiting requested review from alculquicondor

Assignees

@alculquicondor alculquicondor

@kerthcet kerthcet

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/feature Categorizes issue or PR as related to a new feature. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Expand testgrids per test
5 participants
@kannon92 @k8s-ci-robot @kerthcet @alculquicondor @BenTheElder