Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable preemption and borrowing based on flavor #849

Merged
merged 28 commits into from Oct 9, 2023
Merged

Enable preemption and borrowing based on flavor #849

merged 28 commits into from Oct 9, 2023

Conversation

KunWuLuan
Copy link
Contributor

@KunWuLuan KunWuLuan commented Jun 13, 2023 •
edited by k8s-ci-robot

/kind feature

What type of PR is this?

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #582

Special notes for your reviewer:

Does this PR introduce a user-facing change?

Options to allow workloads to borrow quota or preempt other workloads before trying the next flavor in the list

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/feature Categorizes issue or PR as related to a new feature. labels Jun 13, 2023
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jun 13, 2023
@k8s-ci-robot
Copy link
Contributor

Hi @KunWuLuan. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@netlify
Copy link

netlify bot commented Jun 13, 2023 •
edited

✅ Deploy Preview for kubernetes-sigs-kueue canceled.

Name Link
🔨 Latest commit 50475bd
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-sigs-kueue/deploys/6521150b822cc90008391b19

@k8s-ci-robot k8s-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Jun 13, 2023
@alculquicondor
Copy link
Contributor

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jun 13, 2023
@alculquicondor
Copy link
Contributor

/assign @trasc for a first pass

@trasc
Copy link
Contributor

trasc commented Jun 13, 2023

/assign

trasc
trasc reviewed Jun 13, 2023
View reviewed changes
Copy link
Contributor

@trasc trasc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please try to fix the tests.

apis/kueue/v1beta1/clusterqueue_types.go Outdated Show resolved Hide resolved
pkg/cache/cache.go Outdated Show resolved Hide resolved
pkg/scheduler/flavorassigner/flavorassigner.go Outdated Show resolved Hide resolved
pkg/scheduler/flavorassigner/flavorassigner.go Outdated Show resolved Hide resolved
@alculquicondor alculquicondor changed the title add preempt and borrow based on flavor WIP (prototype) add preempt and borrow based on flavor Jun 15, 2023
@k8s-ci-robot k8s-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jun 15, 2023
alculquicondor
alculquicondor reviewed Jun 15, 2023
View reviewed changes
apis/kueue/v1beta1/clusterqueue_types.go Outdated Show resolved Hide resolved
apis/kueue/v1beta1/clusterqueue_types.go Outdated Show resolved Hide resolved
pkg/scheduler/flavorassigner/flavorassigner.go Show resolved Hide resolved
pkg/scheduler/flavorassigner/flavorassigner.go Outdated Show resolved Hide resolved
pkg/scheduler/flavorassigner/flavorassigner.go Outdated Show resolved Hide resolved
@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jun 20, 2023
@KunWuLuan
Copy link
Contributor Author

/test all

@KunWuLuan
Copy link
Contributor Author

/retest

@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jul 4, 2023
@KunWuLuan
Copy link
Contributor Author

/retest

@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jul 4, 2023
@KunWuLuan KunWuLuan force-pushed the feature/pbnf branch 2 times, most recently from c2db27a to 3eac3ed Compare July 5, 2023 11:53
@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Sep 28, 2023
@trasc trasc mentioned this pull request Sep 28, 2023
Closed
@tenzen-y
Copy link
Member

I'm still waiting for some comments.

tenzen-y
tenzen-y reviewed Sep 29, 2023
View reviewed changes
pkg/cache/cache_test.go Outdated Show resolved Hide resolved
@alculquicondor
Copy link
Contributor

hi @KunWuLuan we are approaching the time for the next release. Can you follow up on the last suggestions?

@tenzen-y
Copy link
Member

tenzen-y commented Oct 3, 2023

hi @KunWuLuan we are approaching the time for the next release. Can you follow up on the last suggestions?

I'm still waiting for the following:

@KunWuLuan
Copy link
Contributor Author

hi @KunWuLuan we are approaching the time for the next release. Can you follow up on the last suggestions?

I'm still waiting for the following:

Sure, for replying late. I am on vacation this week. I will work on these comments this weekend.

@tenzen-y
Copy link
Member

tenzen-y commented Oct 7, 2023

hi @KunWuLuan we are approaching the time for the next release. Can you follow up on the last suggestions?

I'm still waiting for the following:

Sure, for replying late. I am on vacation this week. I will work on these comments this weekend.

Thank you!

@KunWuLuan
move FlavorResourceQuantities to cache
50475bd 
remove Preemption setting in MakeClusterQueue
@KunWuLuan
Copy link
Contributor Author

hi @KunWuLuan we are approaching the time for the next release. Can you follow up on the last suggestions?

I'm still waiting for the following:

Sure, for replying late. I am on vacation this week. I will work on these comments this weekend.

Thank you!

Hi, I have addressed these comments. Please take a look if u have time. Thanks very much.

tenzen-y
tenzen-y reviewed Oct 9, 2023
View reviewed changes
Copy link
Member

@tenzen-y tenzen-y left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@KunWuLuan Thank you for this great work!

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 9, 2023
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 89adafb5589fa6c9b5453691effe6d04c4a343a0

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: alculquicondor, KunWuLuan, tenzen-y

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [alculquicondor,tenzen-y]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tenzen-y
Copy link
Member

tenzen-y commented Oct 9, 2023

/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 9, 2023
@k8s-ci-robot k8s-ci-robot merged commit fe55306 into kubernetes-sigs:main Oct 9, 2023
14 checks passed
@k8s-ci-robot k8s-ci-robot added this to the v0.5 milestone Oct 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alculquicondor alculquicondor alculquicondor left review comments

@trasc trasc trasc left review comments

@tenzen-y tenzen-y tenzen-y left review comments

@ArangoGutierrez ArangoGutierrez Awaiting requested review from ArangoGutierrez

Assignees

@trasc trasc

@tenzen-y tenzen-y

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/feature Categorizes issue or PR as related to a new feature. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Milestone
v0.5
Development

Successfully merging this pull request may close these issues.

Preemption based on resource flavor order
5 participants
@KunWuLuan @k8s-ci-robot @alculquicondor @trasc @tenzen-y