Add validation for child jobs without ownerReference

[tenzen-y]

What type of PR is this?

/kind cleanup

What this PR does / why we need it:

I added validation not to allow child jobs without ownerReference.

Which issue(s) this PR fixes:

Follow-up: #821 (comment)

Special notes for your reviewer:

Does this PR introduce a user-facing change?

Add validation for child jobs without ownerReference.

[netlify]

✅ Deploy Preview for kubernetes-sigs-kueue canceled.

Name	Link
🔨 Latest commit	d8a854e
🔍 Latest deploy log	https://app.netlify.com/sites/kubernetes-sigs-kueue/deploys/6499a91e08eab00008eda9aa

[tenzen-y]

/assign @kerthcet

[tenzen-y]

/test pull-kueue-test-e2e-main-1-26

[tenzen-y]

friendly ping @kerthcet :)

[tenzen-y]

@kerthcet I have addressed your comments. PTAL.

[alculquicondor]

I wonder if we could also check that the owner is a well-known job owner.

And maybe there should be a Kueue configuration that allows to say which other APIs are job owners (in addition to the ones implemented in-tree).
This way, it should be possible to write external integration controllers and tell kueue to trust particular owner references and not suspend the jobs.

Once we have this trust, we can potentially simplify this code and not query weather the parent workload has a queue name

kueue/pkg/controller/jobframework/reconciler.go

Lines 121 to 137 in b463573

	if !r.manageJobsWithoutQueueName && QueueName(job) == "" {
	if isStandaloneJob {
	log.V(3).Info("Neither queue-name label, nor parent-workload annotation is set, ignoring the job",
	"queueName", QueueName(job), "parentWorkload", ParentWorkloadName(job))
	return ctrl.Result{}, nil
	}
	isParentJobManaged, err := r.IsParentJobManaged(ctx, job.Object(), namespacedName.Namespace)
	if err != nil {
	log.Error(err, "couldn't check whether the parent job is managed by kueue")
	return ctrl.Result{}, err
	}
	if !isParentJobManaged {
	log.V(3).Info("parent-workload annotation is set, and the parent job doesn't have a queue-name label, ignoring the job",
	"parentWorkload", ParentWorkloadName(job))
	return ctrl.Result{}, nil
	}
	}

[kerthcet]

Didn't see any disadvantages to trust custom jobs, so I'm ok with this validation.

[tenzen-y]

It sounds good. Let me try to work on the feature in follow-ups.

[alculquicondor]

/lgtm
/approve
/hold
for suggestion, but it can also be a follow up

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: alculquicondor, tenzen-y

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• pkg/controller/OWNERS [alculquicondor]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[tenzen-y]

/lgtm /approve /hold for suggestion, but it can also be a follow up

I would like to work on the feature in follow-ups.
/hold cancel