Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add ACK_GINKGO_DEPRECATIONS ack to clean test logs #89

Merged
merged 2 commits into from
Mar 4, 2022
Merged

Add ACK_GINKGO_DEPRECATIONS ack to clean test logs #89

merged 2 commits into from
Mar 4, 2022

Conversation

ArangoGutierrez
Copy link
Contributor

Signed-off-by: Carlos Eduardo Arango Gutierrez carangog@redhat.com

What type of PR is this?

/kind cleanup

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

TODO: migrate to Ginko v2

@k8s-ci-robot k8s-ci-robot added kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Mar 2, 2022
@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Mar 2, 2022
@ArangoGutierrez
Copy link
Contributor Author

/assign @alculquicondor

alculquicondor
alculquicondor reviewed Mar 4, 2022
View reviewed changes
Makefile Outdated Show resolved Hide resolved
@ArangoGutierrez
Add ACK_GINKGO_DEPRECATIONS ack to clean test logs
6a69f2f 
Signed-off-by: Carlos Eduardo Arango Gutierrez <carangog@redhat.com>
@ArangoGutierrez ArangoGutierrez mentioned this pull request Mar 4, 2022
Closed
@ArangoGutierrez
Add TODO for upgrading ginko
9a66ea8 
Signed-off-by: Carlos Eduardo Arango Gutierrez <carangog@redhat.com>
@alculquicondor
Copy link
Contributor

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 4, 2022
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: alculquicondor, ArangoGutierrez

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 4, 2022
@k8s-ci-robot k8s-ci-robot merged commit a64c95d into kubernetes-sigs:main Mar 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@denkensk denkensk Awaiting requested review from denkensk

@alculquicondor alculquicondor Awaiting requested review from alculquicondor

Assignees

@alculquicondor alculquicondor

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@ArangoGutierrez @alculquicondor @k8s-ci-robot