Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cluster queue resource metrics. #982

Merged
merged 1 commit into from Jul 19, 2023
Merged

Cluster queue resource metrics. #982

merged 1 commit into from Jul 19, 2023

Conversation

trasc
Copy link
Contributor

@trasc trasc commented Jul 13, 2023 •
edited

What type of PR is this?

/kind feature

What this PR does / why we need it:

Add optional cluster queue resource quota and usage metrics.

Which issue(s) this PR fixes:

Fixes #972

Special notes for your reviewer:

Does this PR introduce a user-facing change?

Add optional cluster queue resource quota and usage metrics.

@k8s-ci-robot
Copy link
Contributor

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@k8s-ci-robot k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Jul 13, 2023
@netlify
Copy link

netlify bot commented Jul 13, 2023 •
edited

✅ Deploy Preview for kubernetes-sigs-kueue ready!

Name Link
🔨 Latest commit 59bdc9a
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-sigs-kueue/deploys/64b79578293df90008fef222
😎 Deploy Preview https://deploy-preview-982--kubernetes-sigs-kueue.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@k8s-ci-robot k8s-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Jul 13, 2023
@trasc
Copy link
Contributor Author

trasc commented Jul 13, 2023

/test all

@trasc trasc force-pushed the cq_metrics branch 2 times, most recently from 37db270 to 64dcb2c Compare July 13, 2023 12:18
@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. and removed do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Jul 13, 2023
@trasc trasc marked this pull request as ready for review July 13, 2023 14:03
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jul 13, 2023
trasc
trasc commented Jul 14, 2023
View reviewed changes
Copy link
Contributor Author

@trasc trasc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Using the managers config , docs removed to be added in a PR targeting the website branch.

pkg/metrics/metrics.go Show resolved Hide resolved
alculquicondor
alculquicondor reviewed Jul 14, 2023
View reviewed changes
apis/config/v1beta1/configuration_types.go Outdated Show resolved Hide resolved
pkg/controller/core/clusterqueue_controller.go Show resolved Hide resolved
pkg/metrics/metrics.go Outdated Show resolved Hide resolved
pkg/metrics/metrics.go Outdated Show resolved Hide resolved
pkg/metrics/metrics.go Outdated Show resolved Hide resolved
pkg/metrics/metrics.go Show resolved Hide resolved
pkg/metrics/metrics.go Outdated Show resolved Hide resolved
pkg/metrics/metrics.go Outdated Show resolved Hide resolved
pkg/util/resource/resource.go Show resolved Hide resolved
@k8s-ci-robot k8s-ci-robot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jul 18, 2023
alculquicondor
alculquicondor reviewed Jul 18, 2023
View reviewed changes
apis/config/v1beta1/configuration_types.go Outdated Show resolved Hide resolved
pkg/controller/core/clusterqueue_controller.go Outdated Show resolved Hide resolved
pkg/controller/core/clusterqueue_controller.go Outdated Show resolved Hide resolved
pkg/controller/core/clusterqueue_controller.go Outdated Show resolved Hide resolved
pkg/util/resource/resource_test.go Outdated Show resolved Hide resolved
pkg/util/maps/maps.go Show resolved Hide resolved
pkg/util/slices/slices.go Outdated Show resolved Hide resolved
pkg/controller/core/clusterqueue_controller_test.go Outdated Show resolved Hide resolved
pkg/controller/core/clusterqueue_controller_test.go Outdated Show resolved Hide resolved
alculquicondor
alculquicondor reviewed Jul 19, 2023
View reviewed changes
Copy link
Contributor

@alculquicondor alculquicondor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 19, 2023
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: alculquicondor, trasc

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 19, 2023
@k8s-ci-robot k8s-ci-robot merged commit a103723 into kubernetes-sigs:main Jul 19, 2023
15 checks passed
@k8s-ci-robot k8s-ci-robot added this to the v0.4 milestone Jul 19, 2023
@trasc trasc deleted the cq_metrics branch July 20, 2023 08:03
@alculquicondor
Copy link
Contributor

/kind feature

@k8s-ci-robot k8s-ci-robot added the kind/feature Categorizes issue or PR as related to a new feature. label Oct 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alculquicondor alculquicondor alculquicondor left review comments

@ArangoGutierrez ArangoGutierrez Awaiting requested review from ArangoGutierrez

@ahg-g ahg-g Awaiting requested review from ahg-g

@denkensk denkensk Awaiting requested review from denkensk

Assignees

@alculquicondor alculquicondor

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/feature Categorizes issue or PR as related to a new feature. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Milestone
v0.4
Development

Successfully merging this pull request may close these issues.

Add metrics for ClusterQueue usage
3 participants
@trasc @k8s-ci-robot @alculquicondor