helmChartInflationGenerator doesn't appear to work properly with local charts

[rbkaspr]

Describe the bug
I'm attempting to take advantage of the helmChartInflationGenerator plugin to combine a locally stored, unpackaged Helm chart with a few pre- and post-install artifacts. The issue I'm running into is that the plugin always seems to be trying to reach out to the legacy stable chart repo, even if chartRepoUrl is unset and chartHome is set to the location of the unpackaged chart. Even with some mucking around with the settings, it appears that the plugin expects a properly packaged (.tar.gz) chart at whatever location it's looking in. We keep these charts vendored in our Git repo along with the Kustomize manifests because they've been modified for our particular usecase.

Files that can reproduce the issue

docs
├── chart
│   └── <unpackaged chart
├── overlay
│   ├── kustomization.yaml
│   ├── values.yaml
│   └── <additionalResources

resources:
- <additionalResources>
helmChartInflationGenerator:
- chartName: sonarqube
  chartHome: ../chart
  values: values.yaml

Expected output

Helm template + additional Kustomize objects

Actual output

Error: Error: repo stable not found
: failed to run command helm pull --untar --untardir ../chart stable/sonarqube

Kustomize version
v4.0.4

Platform
Linux

Additional context
Helm 3.5.2

[snuggie12]

depends on the contents of < unpackaged chart I think. The local check sees if there's a directory named chartHome/chartName so I think if you had docs/chart/sonarqube/Chart.yaml it would work.

[KnVerey]

Thanks for the report @rbkaspr ! It looks like you're right that local charts aren't supported right now. We would gladly accept PRs to:

1. Improve the error message in the meantime.
2. Implement local chart support.

Would you be interested in helping with either of those? The code for the helm generator is here: https://github.com/kubernetes-sigs/kustomize/blob/master/api/builtins/HelmChartInflationGenerator.go

/help
/triage accepted
/kind feature

[k8s-ci-robot]

@KnVerey:
This request has been marked as needing help from a contributor.

Please ensure the request meets the requirements listed here.

If this request no longer meets these requirements, the label can be removed
by commenting with the /remove-help command.

In response to this:

Thanks for the report @rbkaspr ! It looks like you're right that local charts aren't supported right now. We would gladly accept PRs to:

1. Improve the error message in the meantime.
2. Implement local chart support.

Would you be interested in helping with either of those? The code for the helm generator is here: https://github.com/kubernetes-sigs/kustomize/blob/master/api/builtins/HelmChartInflationGenerator.go

/help
/triage accepted
/kind feature

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[KnVerey]

/remove-label needs-triage

[k8s-ci-robot]

@KnVerey: The label(s) /remove-label needs-triage cannot be applied. These labels are supported: api-review, tide/merge-method-merge, tide/merge-method-rebase, tide/merge-method-squash, team/katacoda

In response to this:

/remove-label needs-triage

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[k8s-triage-robot]

The Kubernetes project currently lacks enough contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

• After 90d of inactivity, lifecycle/stale is applied
• After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
• After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

• Mark this issue or PR as fresh with /remove-lifecycle stale
• Mark this issue or PR as rotten with /lifecycle rotten
• Close this issue or PR with /close
• Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

[k8s-triage-robot]

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

• After 90d of inactivity, lifecycle/stale is applied
• After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
• After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

• Mark this issue or PR as fresh with /remove-lifecycle rotten
• Close this issue or PR with /close
• Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle rotten

[k8s-triage-robot]

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

• After 90d of inactivity, lifecycle/stale is applied
• After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
• After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

• Reopen this issue or PR with /reopen
• Mark this issue or PR as fresh with /remove-lifecycle rotten
• Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/close

[k8s-ci-robot]

@k8s-triage-robot: Closing this issue.

In response to this:

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

• After 90d of inactivity, lifecycle/stale is applied
• After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
• After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

• Reopen this issue or PR with /reopen
• Mark this issue or PR as fresh with /remove-lifecycle rotten
• Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.