Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

helmCharts doesn't support APIVersions #3816

Closed
james-callahan opened this issue Apr 19, 2021 · 18 comments · Fixed by #4926
Closed

helmCharts doesn't support APIVersions #3816

james-callahan opened this issue Apr 19, 2021 · 18 comments · Fixed by #4926
Labels
area/helm kind/feature Categorizes issue or PR as related to a new feature. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Milestone
v5.0.0

Comments

@james-callahan
Copy link
Contributor

Similar to #3458

The new helmCharts feature (#3784) needs a way to pass in APIVersions.

CC @monopole
@Shell32-Natsu Shell32-Natsu added the kind/feature Categorizes issue or PR as related to a new feature. label Apr 19, 2021
@Shell32-Natsu
Copy link
Contributor

For every possible option that will be passed to helm we should have a field in the plugin config.

@Shell32-Natsu Shell32-Natsu mentioned this issue Apr 19, 2021
Closed
@drivelikebrazil drivelikebrazil mentioned this issue Apr 20, 2021
Closed
@Shell32-Natsu Shell32-Natsu added the triage/accepted Indicates an issue or PR is ready to be actively worked on. label Apr 20, 2021
@qkflies qkflies mentioned this issue Apr 22, 2021
Closed
@monopole
Copy link
Contributor

#3815 (comment)

@fejta-bot
Copy link

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-contributor-experience at kubernetes/community.
/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jul 22, 2021
@james-callahan
Copy link
Contributor Author

.

@james-callahan
Copy link
Contributor Author

hmm. why didn't @fejta-bot remove the stale label when I commented?

@k8s-triage-robot
Copy link

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Mark this issue or PR as fresh with /remove-lifecycle rotten
  • Close this issue or PR with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle rotten

@k8s-ci-robot k8s-ci-robot added lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Aug 22, 2021
@james-callahan
Copy link
Contributor Author

/remove-lifecycle rotten

@k8s-ci-robot k8s-ci-robot removed the lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. label Aug 24, 2021
@k8s-triage-robot
Copy link

The Kubernetes project currently lacks enough contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Mark this issue or PR as fresh with /remove-lifecycle stale
  • Mark this issue or PR as rotten with /lifecycle rotten
  • Close this issue or PR with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Nov 22, 2021
@james-callahan
Copy link
Contributor Author

/remove-lifecycle rotten

@natasha41575 natasha41575 added area/helm and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Jan 6, 2022
@natasha41575
Copy link
Contributor

We will be supporting this in the next iteration of the helm generator.

@natasha41575 natasha41575 mentioned this issue Jan 25, 2022
Merged
@k8s-triage-robot
Copy link

The Kubernetes project currently lacks enough contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Mark this issue or PR as fresh with /remove-lifecycle stale
  • Mark this issue or PR as rotten with /lifecycle rotten
  • Close this issue or PR with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Apr 24, 2022
@james-callahan james-callahan mentioned this issue May 7, 2022
Open
@k8s-triage-robot
Copy link

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Mark this issue or PR as fresh with /remove-lifecycle rotten
  • Close this issue or PR with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle rotten

@k8s-ci-robot k8s-ci-robot added lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels May 24, 2022
@highb
Copy link

highb commented May 25, 2022

The lack of any way of specifying APIVersions or other data that is often required by charts (and not passable via values) seriously limits the utility of the helmGenerator for me. Given this limitation, it seems that the better long term solution is to use helm template to generate the manifests required against the cluster they will be deployed to and then check them in as a new base for Kustomize. Unfortunately, that defeats a lot of the purpose of making a Helm chart at all.

I'm eagerly awaiting the planned work to move helmGenerator out into it's own plugin so that the community can add missing features like these.

@highb
Copy link

highb commented May 25, 2022

/remove-lifecycle rotten

@k8s-ci-robot k8s-ci-robot removed the lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. label May 25, 2022
@highb
Copy link

highb commented May 25, 2022

/remove-lifecycle stale

@james-callahan
Copy link
Contributor Author

I'm eagerly awaiting the planned work to move helmGenerator out into it's own plugin so that the community can add missing features like these.

https://github.com/mgoltzsche/khelm already exists
I suggest the current helm generator included with kustomize just gets dropped

@daconstenla daconstenla mentioned this issue Jun 7, 2022
Closed
daconstenla pushed a commit to daconstenla/kustomize that referenced this issue Jun 7, 2022
From kubernetes-sigs#4256 & kubernetes-sigs#3816, this introduces sup…
837015f 
…port for kube-version parameter

used during helm template command execution
@k8s-triage-robot
Copy link

The Kubernetes project currently lacks enough contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Mark this issue or PR as fresh with /remove-lifecycle stale
  • Mark this issue or PR as rotten with /lifecycle rotten
  • Close this issue or PR with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Aug 23, 2022
@CmdrSharp CmdrSharp mentioned this issue Aug 28, 2022
Open
@CmdrSharp
Copy link

/remove-lifecycle stale

@k8s-ci-robot k8s-ci-robot removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Sep 14, 2022
@natasha41575 natasha41575 mentioned this issue Dec 12, 2022
Merged
@natasha41575 natasha41575 added this to the v5.0.0 milestone Dec 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area/helm kind/feature Categorizes issue or PR as related to a new feature. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
None yet
Milestone
v5.0.0
Development

Successfully merging a pull request may close this issue.

support for more helm template args natasha41575/kustomize
9 participants
@highb @monopole @Shell32-Natsu @CmdrSharp @natasha41575 @k8s-ci-robot @fejta-bot @james-callahan @k8s-triage-robot