Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Kustomize stuck on outdated goreleaser version #4542

Closed
KnVerey opened this issue Mar 25, 2022 · 7 comments
Closed

Kustomize stuck on outdated goreleaser version #4542

KnVerey opened this issue Mar 25, 2022 · 7 comments
Labels
kind/releasing issues related to releasing lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness. triage/accepted Indicates an issue or PR is ready to be actively worked on.

Comments

@KnVerey
Copy link
Contributor

KnVerey commented Mar 25, 2022

Kustomize is currently relying on goreleaser's --skip-validate flag to ignore the fact that our tags are not pure semver (because they have module prefixes). That flag was deprecated long ago, and removed in v0.180.0 in Sept 2021. Multi-module repos like our are supposed to move to the "monorepo" feature, which requires a paid Pro license.

#4571 manually installs v0.179.0 into a container with Go 1.18 so that we aren't stuck building with the old Go version the corresponding official goreleaser container bundles. But this is still a risk for us in the medium to long term.

Potential options:

  • Pay for a Pro license?
  • Stop using goreleaser? (what does the rest of the project do?)

FYI @natasha41575 this seems pretty important and may be high effort

@KnVerey KnVerey added the kind/bug Categorizes issue or PR as related to a bug. label Mar 25, 2022
@k8s-ci-robot
Copy link
Contributor

@KnVerey: This issue is currently awaiting triage.

SIG CLI takes a lead on issue triage for this repo, but any Kubernetes member can accept issues by applying the triage/accepted label.

The triage/accepted label can be added by org members by writing /triage accepted in a comment.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. label Mar 25, 2022
@KnVerey KnVerey added kind/releasing issues related to releasing triage/accepted Indicates an issue or PR is ready to be actively worked on. and removed kind/bug Categorizes issue or PR as related to a bug. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Mar 25, 2022
@k8s-triage-robot
Copy link

The Kubernetes project currently lacks enough contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Mark this issue or PR as fresh with /remove-lifecycle stale
  • Mark this issue or PR as rotten with /lifecycle rotten
  • Close this issue or PR with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jul 5, 2022
@KnVerey KnVerey added lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Jul 5, 2022
@KnVerey KnVerey mentioned this issue Mar 29, 2023
6 tasks
@jzelinskie
Copy link

jzelinskie commented Jul 3, 2023

I think you should just purchase goreleaser and support @caarlos0

The CNCF provides budget for things like this. I believe you just need to use the service desk.

@caarlos0
Copy link

caarlos0 commented Jul 4, 2023

I'm also happy to give a discount as it is for OSS :)

@pre
Copy link

pre commented Jul 4, 2023

If there’s budget, I don’t understand the urge to ”not pay” for useful tools.

The cumulative cost for finding an alternative is of course zero if the voluntary work doesn’t cost anything (except if someone performs this as part of their salary job ..)

I doubt the license cost is that much for an open source project, especially if there’s support from the author.

@koba1t
Copy link
Member

koba1t commented Aug 31, 2023

I think this issue was resolved with merge for #5239.
/close

@k8s-ci-robot
Copy link
Contributor

@koba1t: Closing this issue.

In response to this:

I think this issue was resolved with merge for #5239.
/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/releasing issues related to releasing lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
None yet
Development

No branches or pull requests

7 participants