Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove SopsEncodedSecretsPlugin #1238

Merged

Conversation

monopole
Copy link
Contributor

@monopole monopole commented Jun 23, 2019

Undoes #1214, which brought in too many deps.

This plugin belongs in some other repo, e.g. an updated version of https://github.com/Agilicus/kustomize-sops

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Jun 23, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: monopole

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 23, 2019
@monopole monopole merged commit 3127f1a into kubernetes-sigs:master Jun 23, 2019
@sknigh
Copy link

sknigh commented Jun 24, 2019

@monopole Does Kustomize plan to have first party support for SOPS or some other secret encryption scheme in the future?

@monopole
Copy link
Contributor Author

Once a plugin like this is established as useful, we can easily make it a builtin.

PTAL at https://github.com/kubernetes-sigs/kustomize/blob/master/docs/plugins/goPluginGuidedExample.md

see if it works for you. This is alpha doc, looking for feedback.

@monopole monopole deleted the removeSopsEncodedSecretsPlugin branch June 28, 2019 15:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants