Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove site and docs folder #4491

Closed

Conversation

rob8714
Copy link
Contributor

@rob8714 rob8714 commented Feb 25, 2022

Removes the site and docs folder to tackle #3915

Pages that did not have redirects:

docs/authoring.md - partially migrated in kubernetes-sigs/cli-experimental#244
docs/guides/cmd - migrated in kubernetes-sigs/cli-experimental#244
docs/inventory_object.md - page was marked as deprecated
site/content/en/blog/releases/v* - content already present in cli-experimental
content/en/_index.md, content/zh/_index.md, content/en/search*.md, content/zn/search* - don't think these would need to be tackled

@k8s-ci-robot
Copy link
Contributor

@rob8714: This PR has multiple commits, and the default merge method is: merge.
You can request commits to be squashed using the label: tide/merge-method-squash

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Feb 25, 2022
@k8s-ci-robot
Copy link
Contributor

Welcome @rob8714!

It looks like this is your first PR to kubernetes-sigs/kustomize 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/kustomize has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Feb 25, 2022
@k8s-ci-robot
Copy link
Contributor

Hi @rob8714. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Feb 25, 2022
@KnVerey
Copy link
Contributor

KnVerey commented Feb 25, 2022

I agree with your assessment of the content.

Since this is impossible to view on Github, to sanity check it, I pulled the branch locally and confirmed that only the expected directories are affected: git diff --name-only HEAD~2 -- ':!docs/' ':!site/'

/lgtm
/ok-to-test
/hold on merging kubernetes-sigs/cli-experimental#244 and deactivating the site publishing these files

@k8s-ci-robot k8s-ci-robot added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Feb 25, 2022
@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 25, 2022
…ted overlays.jpg to remove reference to 'bases'
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 27, 2022
@k8s-ci-robot
Copy link
Contributor

New changes are detected. LGTM label has been removed.

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: rob8714
To complete the pull request process, please ask for approval from knverey after the PR has been reviewed.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@rob8714
Copy link
Contributor Author

rob8714 commented Feb 27, 2022

Noticed that some images in README were going to break, copied over the base.jpg and overlay.jpg into a new images folder and additionally fixed overlay.jpg to remove the reference to bases (#1555)

Install arch appropriate build if the 'arch' command is present
@KnVerey
Copy link
Contributor

KnVerey commented Feb 28, 2022

Great catch on those images! I just took the site down. Assuming nothing unexpected comes up as a result, I'll merge this tomorrow morning.

@KnVerey
Copy link
Contributor

KnVerey commented Mar 2, 2022

#4500 reported a few places we missed on kustomize.io and the readme. I opened PRs and unfortunately caused a merge conflict for this PR in the process. Can you rebase please? (sorry)

@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Mar 2, 2022
@KnVerey
Copy link
Contributor

KnVerey commented Mar 2, 2022

Fixes #3915

@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Mar 2, 2022
@rob8714
Copy link
Contributor Author

rob8714 commented Mar 2, 2022

Rebase done. Should also fix #1555

@KnVerey KnVerey added the tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges. label Mar 2, 2022
@KnVerey
Copy link
Contributor

KnVerey commented Mar 2, 2022

I think something went wrong with the rebase, as I'm now seeing 14 commits in the history here.

@rob8714
Copy link
Contributor Author

rob8714 commented Mar 2, 2022

Hmm I checked it again and from what I see changes that will be applied are those from this PR only:

image

Checked also

git diff --name-only HEAD~4 -- ':!docs/' ':!site/'
README.md
images/base.jpg
images/overlay.jpg

image

If it's easier I can redo the changes in a new PR

@KnVerey
Copy link
Contributor

KnVerey commented Mar 2, 2022

Yeah the last four are still yours, but this PR is now showing a bunch of other already merged commits before it: https://github.com/kubernetes-sigs/kustomize/pull/4491/commits. I'm not sure why this is happening. I'd suggest git rebase -i master and make sure to remove any commits showing that aren't supposed to be part of this PR. Remaking the PR by checking a new branch off master and cherry-picking would also work--whatever is easiest for you.

@rob8714
Copy link
Contributor Author

rob8714 commented Mar 2, 2022

Went with a new PR - #4504

@rob8714 rob8714 closed this Mar 2, 2022
@rob8714 rob8714 deleted the remove-site-and-docs-folder branch March 2, 2022 20:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants