-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove site and docs folder #4491
Remove site and docs folder #4491
Conversation
@rob8714: This PR has multiple commits, and the default merge method is: merge. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Welcome @rob8714! |
Hi @rob8714. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
I agree with your assessment of the content. Since this is impossible to view on Github, to sanity check it, I pulled the branch locally and confirmed that only the expected directories are affected: /lgtm |
…ted overlays.jpg to remove reference to 'bases'
New changes are detected. LGTM label has been removed. |
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: rob8714 The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Noticed that some images in README were going to break, copied over the base.jpg and overlay.jpg into a new |
Install arch appropriate build if the 'arch' command is present
Great catch on those images! I just took the site down. Assuming nothing unexpected comes up as a result, I'll merge this tomorrow morning. |
#4500 reported a few places we missed on kustomize.io and the readme. I opened PRs and unfortunately caused a merge conflict for this PR in the process. Can you rebase please? (sorry) |
Fixes #3915 |
fix: broken reference to roadmap objectives
…ted overlays.jpg to remove reference to 'bases'
Rebase done. Should also fix #1555 |
I think something went wrong with the rebase, as I'm now seeing 14 commits in the history here. |
Yeah the last four are still yours, but this PR is now showing a bunch of other already merged commits before it: https://github.com/kubernetes-sigs/kustomize/pull/4491/commits. I'm not sure why this is happening. I'd suggest |
Went with a new PR - #4504 |
Removes the site and docs folder to tackle #3915
Pages that did not have redirects:
docs/authoring.md - partially migrated in kubernetes-sigs/cli-experimental#244
docs/guides/cmd - migrated in kubernetes-sigs/cli-experimental#244
docs/inventory_object.md - page was marked as deprecated
site/content/en/blog/releases/v* - content already present in cli-experimental
content/en/_index.md, content/zh/_index.md, content/en/search*.md, content/zn/search* - don't think these would need to be tackled