-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix install_kustomize.sh #5190
base: master
Are you sure you want to change the base?
Fix install_kustomize.sh #5190
Conversation
Welcome @bewing! |
Hi @bewing. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
b5e9c16
to
3cd15fa
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Works on my end:
/bin/bash ./hack/install_kustomize.sh
v5.0.3
kustomize installed to /home/oxr463/src/kustomize/kustomize
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
approved
I have tested it too. It works for me.
|
/assign |
The Kubernetes project currently lacks enough contributors to adequately respond to all PRs. This bot triages PRs according to the following rules:
You can:
Please send feedback to sig-contributor-experience at kubernetes/community. /lifecycle stale |
/remove-lifecycle stale |
Thanks for your kontribution @bewing ! /ok-to-test |
Github recently changed their API to remove whitespace from JSON responses. This commit updates the find_release_url bash function to use grep's --only-matching option to return just the browser_download_url keys and values regardless of whitespace.
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: Aisuko, bewing, oxr463 The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Hi, Thank you for your contribution. I am not able to reproduce the issue described in #4769. The zsh --version
zsh 5.9 (x86_64-apple-darwin23.0)
grep --version
grep (BSD grep, GNU compatible) 2.6.0-FreeBSD # Install kustomize version 5.3.0 in tmp directory
$ ./hack/install_kustomize.sh 5.3.0 tmp
v5.3.0
kustomize installed to /Users/nick/go/src/github.com/ncapps/kustomize/tmp/kustomize
# Verify kustomize 5.3.0 is installed
$ tmp/kustomize version
v5.3.0
# Install kustomize version 5.2.1 in tmp directory
$ ./hack/install_kustomize.sh 5.2.1 tmp
v5.2.1
kustomize installed to /Users/nick/go/src/github.com/ncapps/kustomize/tmp/kustomize
# Verify kustomize 5.2.1 is installed
$ tmp/kustomize version
v5.2.1 |
I'm still seeing single-line output from the Github API in my location (Chicago, IL)
|
Github recently changed their API to sometimes remove whitespace from JSON responses. This commit updates the
find_release_url
bash function to use grep's--only-matching option
to return just thebrowser_download_url
keys and values regardless of whitespace.I was able to test the regex against old and new by passing the JSON document through
jq
first:closes #4769