Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

variant link update #5227

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

variant link update #5227

wants to merge 1 commit into from

Conversation

kundan2707
Copy link
Contributor

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jun 28, 2023
@kundan2707
Copy link
Contributor Author

FIxes: #5224

@kundan2707
Copy link
Contributor Author

/kind documentation

@k8s-ci-robot k8s-ci-robot added the kind/documentation Categorizes issue or PR as related to documentation. label Jun 28, 2023
Aisuko
Aisuko approved these changes Jun 30, 2023
View reviewed changes
Copy link

@Aisuko Aisuko left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

approved

@Aisuko
Copy link

Aisuko commented Jun 30, 2023

/assign

FrenchBen
FrenchBen approved these changes Jul 6, 2023
View reviewed changes
Copy link

@FrenchBen FrenchBen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Aisuko
Copy link

Aisuko commented Jul 7, 2023

cc @koba1t can we get permission to merge these useful PRs?

@koba1t
Copy link
Member

koba1t commented Aug 24, 2023

Hi @kundan2707
Thanks for your contribution!

Looks like this dead link is currently used in many places.
Could you update links in other places?

https://github.com/search?q=repo%3Akubernetes-sigs%2Fkustomize+..%2Fdocs%2Fglossary.md%23variant&type=code

@charles-chenzz charles-chenzz mentioned this pull request Oct 13, 2023
Closed
@kundan2707
Copy link
Contributor Author

@koba1t OK i will update link at every place

@natasha41575 natasha41575 assigned koba1t and unassigned Aisuko Oct 20, 2023
@natasha41575
Copy link
Contributor

@kundan2707 do you plan to update this PR?

@kundan2707
Copy link
Contributor Author

@natasha41575 yes i will update at every place

@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jan 11, 2024
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: Aisuko, FrenchBen, kundan2707
Once this PR has been reviewed and has the lgtm label, please ask for approval from koba1t. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kundan2707
Copy link
Contributor Author

@natasha41575 i have updated it at every place. Can you PTAL?

@koba1t
Copy link
Member

koba1t commented Feb 2, 2024 •
edited

Thanks @kundan2707

But the below additional lines are using this link. Can you fix that?
https://github.com/search?q=repo%3Akubernetes-sigs%2Fkustomize+%22%5Bvariant%5D%3A+..%2F%22&type=code

@kundan2707
Copy link
Contributor Author

@koba1t yes i will fix in additional line too

@k8s-triage-robot
Copy link

The Kubernetes project currently lacks enough contributors to adequately respond to all PRs.

This bot triages PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the PR is closed

You can:

  • Mark this PR as fresh with /remove-lifecycle stale
  • Close this PR with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label May 2, 2024
@k8s-triage-robot
Copy link

The Kubernetes project currently lacks enough active contributors to adequately respond to all PRs.

This bot triages PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the PR is closed

You can:

  • Mark this PR as fresh with /remove-lifecycle rotten
  • Close this PR with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle rotten

@k8s-ci-robot k8s-ci-robot added lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Jun 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FrenchBen FrenchBen FrenchBen approved these changes

@Aisuko Aisuko Aisuko approved these changes

@annasong20 annasong20 Awaiting requested review from annasong20

@koba1t koba1t Awaiting requested review from koba1t

Assignees

@koba1t koba1t

Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/documentation Categorizes issue or PR as related to documentation. lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
Kustomize Documentation
Status: Needs Approval
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@kundan2707 @Aisuko @koba1t @natasha41575 @k8s-ci-robot @k8s-triage-robot @FrenchBen