feat: add exec-plugin argument and environment support #5316

xvzf · 2023-09-05T15:24:47Z

Previously, the documentation lead to think that this is working, but
it's not been implemented.

This PR is fixing this!

I've not seen any test cases for the exec plugins, can you point me to them please?

Signed-off-by: Matthias Riegler matthias.riegler@ankorstore.com

k8s-ci-robot · 2023-09-05T15:24:55Z

Welcome @xvzf!

It looks like this is your first PR to kubernetes-sigs/kustomize 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/kustomize has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

k8s-ci-robot · 2023-09-05T15:24:56Z

Hi @xvzf. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

koba1t · 2023-09-06T19:32:43Z

@xvzf

We have already decided not to add environment support in kustomize.

https://kubectl.docs.kubernetes.io/faq/kustomize/eschewedfeatures/#build-time-side-effects-from-cli-args-or-env-variables

We have the list of Eschewed Features that this project will not support. Please check this page before considering requests for any new feature.

If I misunderstood your request, Feel free to open a feature request issue and tell me what you want.

/close

k8s-ci-robot · 2023-09-06T19:32:48Z

@koba1t: Closed this PR.

In response to this:

@xvzf

We have already decided not to add environment support in kustomize.

https://kubectl.docs.kubernetes.io/faq/kustomize/eschewedfeatures/#build-time-side-effects-from-cli-args-or-env-variables

We have the list of Eschewed Features that this project will not support. Please check this page before considering requests for any new feature.

If I misunderstood your request, Feel free to open a feature request issue and tell me what you want.

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

xvzf · 2023-09-07T13:24:36Z

Hey @koba1t this is not adding environment support to kustomize but implement the functionality that's already there for container-based functions.
I'll open an issue later today with some examples

xvzf · 2023-10-10T13:59:38Z

Hey @koba1t - it took a long time, had to work on other things -- the issue is up now!

xvzf · 2023-11-14T18:31:06Z

@koba1t is there a way to re-open the PR?

koba1t · 2023-11-15T04:54:40Z

Currently, I am talking with other maintainers.
Please wait a little more time to make a decision for this feature.

xvzf · 2023-11-20T09:41:49Z

thanks for the feedback @koba1t!

koba1t · 2023-11-23T17:04:17Z

/reopen

k8s-ci-robot · 2023-11-23T17:04:22Z

@koba1t: Reopened this PR.

In response to this:

/reopen

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

k8s-ci-robot · 2023-11-23T17:04:28Z

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: xvzf
Once this PR has been reviewed and has the lgtm label, please assign natasha41575 for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Previously, the documentation lead to think that this is working, but it's not been implemented. This PR is fixing this Signed-off-by: Matthias Riegler <matthias.riegler@ankorstore.com>

xvzf · 2023-11-27T16:47:13Z

will. fix the listing tmrw!

Signed-off-by: Matthias Riegler <matthias.riegler@ankorstore.com>

k8s-ci-robot · 2023-11-30T16:01:59Z

This PR has multiple commits, and the default merge method is: merge.
You can request commits to be squashed using the label: tide/merge-method-squash

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

xvzf · 2023-12-11T09:36:44Z

Hey @koba1t is there anything missing I should add? :)

varshaprasad96 · 2024-01-03T18:52:42Z

kyaml/runfn/runfn.go

@@ -303,6 +303,28 @@ func (r RunFns) mergeContainerEnv(envs []string) []string {
 	return declarative.Raw()
 }

+// mergeExecEnv will merge the envs specified by command line (imperative) and config
+// file (declarative). If they have same key, the imperative value will be respected.


@xvzf if the same value is specified through command line and env var, would it make sense to error out instead?

I'm fine with any option that makes sense from the user perspective - as this is a one off case with exec functions. We would just need to explicitly specify docs on the stance we take.

cc: @koba1t @natasha41575

Hey

It's the same behavior as for the container env merging (aka CLI flag takes precedence). Afaik it's the default behavior in most applications. Open to change/document it though!

k8s-triage-robot · 2024-04-03T17:01:07Z

The Kubernetes project currently lacks enough contributors to adequately respond to all PRs.

This bot triages PRs according to the following rules:

After 90d of inactivity, lifecycle/stale is applied
After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
After 30d of inactivity since lifecycle/rotten was applied, the PR is closed

You can:

Mark this PR as fresh with /remove-lifecycle stale
Close this PR with /close
Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

xvzf · 2024-04-05T12:09:59Z

@varshaprasad96 @koba1t is there any chance this is getting merged? :)

/remove-lifecycle stale

k8s-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Sep 5, 2023

k8s-ci-robot requested review from annasong20 and natasha41575 September 5, 2023 15:24

k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Sep 5, 2023

k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Sep 5, 2023

k8s-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Sep 5, 2023

xvzf marked this pull request as ready for review September 5, 2023 15:30

k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Sep 5, 2023

k8s-ci-robot requested a review from koba1t September 5, 2023 15:30

xvzf force-pushed the feat/add-alpha-plugin-exec-arg-and-env-support branch from 3ff3bf5 to 570c8bc Compare September 5, 2023 15:32

k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Sep 5, 2023

xvzf force-pushed the feat/add-alpha-plugin-exec-arg-and-env-support branch 2 times, most recently from fe9c6e7 to 4311450 Compare September 5, 2023 15:35

k8s-ci-robot closed this Sep 6, 2023

xvzf mentioned this pull request Oct 10, 2023

KRM functions are behaving differently for exec and container functions #5371

Open

k8s-ci-robot reopened this Nov 23, 2023

feat: add exec-plugin argument and environment support

4f7b20f

Previously, the documentation lead to think that this is working, but it's not been implemented. This PR is fixing this Signed-off-by: Matthias Riegler <matthias.riegler@ankorstore.com>

chore: disable linting for env var split

1918d08

Signed-off-by: Matthias Riegler <matthias.riegler@ankorstore.com>

xvzf force-pushed the feat/add-alpha-plugin-exec-arg-and-env-support branch from 4311450 to 1918d08 Compare November 30, 2023 16:01

varshaprasad96 reviewed Jan 3, 2024

View reviewed changes

k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Apr 3, 2024

k8s-ci-robot removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Apr 5, 2024

xvzf requested a review from varshaprasad96 April 16, 2024 07:38

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: add exec-plugin argument and environment support #5316

feat: add exec-plugin argument and environment support #5316

xvzf commented Sep 5, 2023 •

edited

k8s-ci-robot commented Sep 5, 2023

k8s-ci-robot commented Sep 5, 2023

koba1t commented Sep 6, 2023

k8s-ci-robot commented Sep 6, 2023

xvzf commented Sep 7, 2023

xvzf commented Oct 10, 2023

xvzf commented Nov 14, 2023

koba1t commented Nov 15, 2023

xvzf commented Nov 20, 2023

koba1t commented Nov 23, 2023

k8s-ci-robot commented Nov 23, 2023

k8s-ci-robot commented Nov 23, 2023

xvzf commented Nov 27, 2023

k8s-ci-robot commented Nov 30, 2023

xvzf commented Dec 11, 2023

varshaprasad96 Jan 3, 2024

xvzf Jan 4, 2024

k8s-triage-robot commented Apr 3, 2024

xvzf commented Apr 5, 2024

feat: add exec-plugin argument and environment support #5316

Are you sure you want to change the base?

feat: add exec-plugin argument and environment support #5316

Conversation

xvzf commented Sep 5, 2023 • edited

k8s-ci-robot commented Sep 5, 2023

k8s-ci-robot commented Sep 5, 2023

koba1t commented Sep 6, 2023

k8s-ci-robot commented Sep 6, 2023

xvzf commented Sep 7, 2023

xvzf commented Oct 10, 2023

xvzf commented Nov 14, 2023

koba1t commented Nov 15, 2023

xvzf commented Nov 20, 2023

koba1t commented Nov 23, 2023

k8s-ci-robot commented Nov 23, 2023

k8s-ci-robot commented Nov 23, 2023

xvzf commented Nov 27, 2023

k8s-ci-robot commented Nov 30, 2023

xvzf commented Dec 11, 2023

varshaprasad96 Jan 3, 2024

Choose a reason for hiding this comment

xvzf Jan 4, 2024

Choose a reason for hiding this comment

k8s-triage-robot commented Apr 3, 2024

xvzf commented Apr 5, 2024

xvzf commented Sep 5, 2023 •

edited