fix: flaky ConfigMap/Secret args tests #5455
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Fix a mistake in the comparison between elements in the ConfigMap and Secret args test that causes it to become flaky. * Rename the package in configmapSecretFlagsAndArgs_test.go back to util since the testpackage linter has been disabled.
k8s-ci-robot
added
the
cncf-cla: yes
k8s-ci-robot
added
the
size/XS
| @@ -1,15 +1,14 @@ | |||
| // Copyright 2019 The Kubernetes Authors. | |||
| // SPDX-License-Identifier: Apache-2.0 | |||
There was a problem hiding this comment.
copyright should only be updated when net-new files are added. Existing files should keep their original copyright date.
k8s-ci-robot
added
the
lgtm
natasha41575
approved these changes
Nov 20, 2023
| @@ -1,15 +1,14 @@ | |||
| // Copyright 2019 The Kubernetes Authors. | |||
| // SPDX-License-Identifier: Apache-2.0 | |||
There was a problem hiding this comment.
copyright should only be updated when net-new files are added. Existing files should keep their original copyright date.
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: natasha41575, stormqueen1990 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
configmapSecretFlagsAndArgs_test.goback to util since the testpackage linter has been disabled.