Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: flaky ConfigMap/Secret args tests #5455

Merged
merged 1 commit into from Nov 20, 2023
Merged

fix: flaky ConfigMap/Secret args tests #5455

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
5 changes: 2 additions & 3 deletions kustomize/commands/internal/util/configmapSecretFlagsAndArgs_test.go
View file
Open in desktop
@@ -1,15 +1,14 @@
// Copyright 2019 The Kubernetes Authors.
// SPDX-License-Identifier: Apache-2.0
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

non-blocking nit: 2023

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

copyright should only be updated when net-new files are added. Existing files should keep their original copyright date.


package util_test
package util

import (
"reflect"
"testing"

"github.com/stretchr/testify/require"
"sigs.k8s.io/kustomize/api/types"
. "sigs.k8s.io/kustomize/kustomize/v5/commands/internal/util"
"sigs.k8s.io/kustomize/kyaml/filesys"
)

Expand Down Expand Up @@ -349,7 +348,7 @@ func TestUpdateLiteralSources(t *testing.T) {
for _, tc := range testCases {
t.Run(tc.name, func(t *testing.T) {
tc.wantErr(t, UpdateLiteralSources(tc.args, tc.flags))
require.Equal(t, tc.expectedArgs.LiteralSources, tc.args.LiteralSources)
require.ElementsMatch(t, tc.expectedArgs.LiteralSources, tc.args.LiteralSources)
})
}
}