Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: Update to Go v1.21 #5555

Merged
merged 1 commit into from Mar 20, 2024
Merged

chore: Update to Go v1.21 #5555

merged 1 commit into from Mar 20, 2024

Conversation

karlkfi
Copy link
Contributor

@karlkfi karlkfi commented Feb 27, 2024 •
edited

Includes:

  • go mod tidy (all modules)
  • go work sync
  • Fixed plugin generation for Go 1.21
  • Updated linting for Go 1.21
  • Fixed minecraft example for Helm v3 pull download path
  • Update dev docs to mention Go 1.21
  • Regenerate plugins with Go 1.21

Depends on kubernetes/test-infra#31974

Blocking #5535

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Feb 27, 2024
@koba1t
Copy link
Member

koba1t commented Feb 28, 2024

go work sync

In my experience, that is better to run ./hack/doGoMod.sh tidy after running the go work sync command.

@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Feb 28, 2024
@karlkfi karlkfi mentioned this pull request Feb 29, 2024
Merged
@karlkfi
Copy link
Contributor Author

karlkfi commented Mar 5, 2024

go work sync

In my experience, that is better to run ./hack/doGoMod.sh tidy after running the go work sync command.

./hack/doGoMod.sh tidy and hack/for-each-module.sh are basically the same thing, except for-each-module skips site/ modules. But I ran both just in case.

@karlkfi
Copy link
Contributor Author

karlkfi commented Mar 5, 2024

Rebased and fixed plugin generation. make prow-presubmit-check and make verify-kustomize-repo now pass for me locally.

In order for the prow test to pass in prow, the prow config needs to be updated to support Go 1.21: kubernetes/test-infra#31974

@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Mar 5, 2024
@koba1t
Copy link
Member

koba1t commented Mar 14, 2024

/retest

@koba1t
Copy link
Member

koba1t commented Mar 14, 2024

Hi @karlkfi
I approved the PR that upgrades the go version in CI.
So, Could you rebase master this PR to merge?

@koba1t koba1t closed this Mar 14, 2024
@koba1t koba1t reopened this Mar 14, 2024
@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Mar 14, 2024
@k8s-ci-robot
Copy link
Contributor

PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@karlkfi
chore: Update to Go v1.21
4dbc0d2 
- go mod tidy (all modules)
- go work sync
- Fixed plugin generation for Go 1.21
- Updated linting for Go 1.21
- Fixed minecraft example for Helm v3 pull download path
- Update dev docs to mention Go 1.21
- Regenerate plugins with Go 1.21
@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels Mar 15, 2024
@karlkfi
Copy link
Contributor Author

karlkfi commented Mar 15, 2024

Rebased and passed all test!

@karlkfi
Copy link
Contributor Author

karlkfi commented Mar 15, 2024

(Rebasing these is a pain, cause it conflicts with every go.mod and go.sum change.)

@karlkfi karlkfi mentioned this pull request Mar 15, 2024
Closed
@koba1t
Copy link
Member

koba1t commented Mar 16, 2024

Thanks! I'll review.
/assign @koba1t

ncapps
ncapps reviewed Mar 20, 2024
View reviewed changes
Copy link
Contributor

@ncapps ncapps left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 20, 2024
@koba1t
Copy link
Member

koba1t commented Mar 20, 2024

Thanks for your hard work!
This PR looks good. And the tests and lint passed in my computer.
(It's incomprehensible why the tests and lint on the GitHub action weren't run.)

/lgtm
/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: karlkfi, koba1t

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 20, 2024
@k8s-ci-robot k8s-ci-robot merged commit 1eccd8f into kubernetes-sigs:master Mar 20, 2024
10 checks passed
@karlkfi karlkfi deleted the karl-go-121 branch March 25, 2024 18:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ncapps ncapps ncapps left review comments

@koba1t koba1t Awaiting requested review from koba1t

Assignees

@ncapps ncapps

@koba1t koba1t

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@karlkfi @koba1t @k8s-ci-robot @ncapps