Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update kustomize presubmit to Go 1.21 #31974

Merged
merged 1 commit into from Mar 14, 2024

Conversation

karlkfi
Copy link
Contributor

@karlkfi karlkfi commented Feb 13, 2024

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. area/config Issues or PRs related to code in /config labels Feb 13, 2024
@k8s-ci-robot k8s-ci-robot added area/jobs sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Feb 13, 2024
@karlkfi
Copy link
Contributor Author

karlkfi commented Feb 13, 2024

/cc @varshaprasad96 @koba1t

@koba1t
Copy link
Member

koba1t commented Feb 14, 2024

Hi @karlkfi
We need to update the Go version in the Kustomize repo before updating it in CI.

And, We need to do more work to update the go version.
kubernetes-sigs/kustomize#5187

/hold

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Feb 14, 2024
@karlkfi
Copy link
Contributor Author

karlkfi commented Feb 14, 2024

We can't update Go in the kustomize repo until CI is updated, otherwise this presubmit fails and the PR merge is blocked.

I've got all the other presubmits passing in kubernetes-sigs/kustomize#5535

@koba1t
Copy link
Member

koba1t commented Mar 14, 2024

Hi @karlkfi
Thanks for preparing to upgrade to the go1.21!

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 14, 2024
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: karlkfi, koba1t

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 14, 2024
@koba1t
Copy link
Member

koba1t commented Mar 14, 2024

/unhold

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 14, 2024
@k8s-ci-robot k8s-ci-robot merged commit 0975e7a into kubernetes:master Mar 14, 2024
8 checks passed
@k8s-ci-robot
Copy link
Contributor

@karlkfi: Updated the job-config configmap in namespace default at cluster test-infra-trusted using the following files:

  • key kustomize-presubmit-master.yaml using file config/jobs/kubernetes-sigs/kustomize/kustomize-presubmit-master.yaml

In response to this:

Blocking kubernetes-sigs/kustomize#5535 & kubernetes-sigs/kustomize#5555

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@karlkfi karlkfi deleted the karl-kustomize-1.21 branch March 15, 2024 18:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/config Issues or PRs related to code in /config area/jobs cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants