Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] runtime use kind: kind support podman #323

Conversation

helen-frank
Copy link
Contributor

What type of PR is this?

/kind feature

What this PR does / why we need it:

kwok supports the use of podman to create containers when the kwok runtime uses kind.

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

./kwokctl create cluster --name m1 --kwok-controller-image registry.k8s.io/kwok/kwok:v0.1.0 --kwok-controller-binary ./kwok --runtime kind                                                                     ─╯
Creating cluster                                                                                                                                                                                           cluster=m1
Pull image                                                                                                                                                          cluster=m1 image="docker.io/kindest/node:v1.26.0"
Trying to pull docker.io/kindest/node:v1.26.0...
Getting image source signatures
Copying blob 42df5cd88ab7 skipped: already exists
Copying blob 6d5e5cfe27ab done
Copying config 6d3fbfb3da done
Writing manifest to image destination
Storing signatures
6d3fbfb3da60acf11211cbcc146edb60404496f59014e4828a5362fbbe0c087b
Pull image                                                                                                                                                        cluster=m1 image="registry.k8s.io/kwok/kwok:v0.1.0"
Trying to pull registry.k8s.io/kwok/kwok:v0.1.0...
Getting image source signatures
Copying blob 8921db27df28 done
Copying blob eaaebbc40b2e done
Copying config 2b07ec5f9c done
Writing manifest to image destination
Storing signatures
2b07ec5f9c13ad8b771ab7d702838b3e43b22ed7bdc05bac42658729310624eb
Starting cluster                                                                                                                                                                                           cluster=m1
enabling experimental podman provider
Creating cluster "kwok-m1" ...
 ✓ Ensuring node image (docker.io/kindest/node:v1.26.0) 🖼
 ✓ Preparing nodes 📦
 ✓ Writing configuration 📜
 ✓ Starting control-plane 🕹️
 ✓ Installing CNI 🔌
 ✓ Installing StorageClass 💾
 ✓ Waiting ≤ 1m0s for control-plane = Ready ⏳
 • Ready after 14s 💚
Set kubectl context to "kind-kwok-m1"
You can now use your cluster with:

kubectl cluster-info --context kind-kwok-m1
Loaded image
Have a nice day! 👋
ERROR Failed cordon nodecluster=m1 err="/usr/bin/kubectl cordon kwok-m1-control-plane: exit status 1\nE0223 07:25:41.877772  268735 memcache.go:238] couldn't get current server API group list: Get \"https://:33843/api?timeout=32s\": tls: either ServerName or InsecureSkipVerify must be specified in the tls.Config\nE0223 07:25:41.878729  268735 memcache.go:238] couldn't get current server API group list: Get \"https://:33843/api?timeout=32s\": tls: either ServerName or InsecureSkipVerify must be specified in the tls.Config\nE0223 07:25:41.879994  268735 memcache.go:238] couldn't get current server API group list: Get \"https://:33843/api?timeout=32s\": tls: either ServerName or InsecureSkipVerify must be specified in the tls.Config\nE0223 07:25:41.880678  268735 memcache.go:238] couldn't get current server API group list: Get \"https://:33843/api?timeout=32s\": tls: either ServerName or InsecureSkipVerify must be specified in the tls.Config\nUnable to connect to the server: tls: either ServerName or InsecureSkipVerify must be specified in the tls.Config\n"
Cluster is created                                                                                                                                                                             cluster=m1 elapsed=47s
You can now use your cluster with:

    kubectl config use-context kwok-m1

Thanks for using kwok!

We need to study why kind use podman returns an empty ip address,
The temporary solution is to change the server ip in the kubeconfig to 0.0.0.0 for normal use.

This pr needs to wait for the image-load function of kind to be incorporated.
kubernetes-sigs/kind#3109

Does this PR introduce a user-facing change?

NONE

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:


@k8s-ci-robot k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. kind/feature Categorizes issue or PR as related to a new feature. labels Feb 23, 2023
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: helen-frank
Once this PR has been reviewed and has the lgtm label, please assign wzshiming for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Feb 23, 2023
@netlify
Copy link

netlify bot commented Feb 23, 2023

Deploy Preview for k8s-kwok canceled.

Name Link
🔨 Latest commit 963c146
🔍 Latest deploy log https://app.netlify.com/sites/k8s-kwok/deploys/63f73a680a1f550008ae51a1

@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Feb 23, 2023
@k8s-ci-robot
Copy link
Contributor

Hi @helen-frank. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Feb 23, 2023
Signed-off-by: helen <haitao.zhang@daocloud.io>
@wzshiming
Copy link
Member

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Feb 23, 2023
@k8s-ci-robot
Copy link
Contributor

PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@wzshiming
Copy link
Member

Fixed by #574
/close

@k8s-ci-robot
Copy link
Contributor

@wzshiming: Closed this PR.

In response to this:

Fixed by #574
/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. kind/feature Categorizes issue or PR as related to a new feature. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants