Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[kwokctl] Add kind-podman as the kwoctkl runtime #574

Merged
merged 1 commit into from
May 8, 2023

Conversation

wzshiming
Copy link
Member

@wzshiming wzshiming commented May 7, 2023

What type of PR is this?

/kind feature

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #566

Special notes for your reviewer:

Does this PR introduce a user-facing change?

Add kind-podman as the kwoctkl runtime

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

NONE

@k8s-ci-robot k8s-ci-robot added kind/feature Categorizes issue or PR as related to a new feature. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels May 7, 2023
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: wzshiming

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@netlify
Copy link

netlify bot commented May 7, 2023

Deploy Preview for k8s-kwok canceled.

Name Link
🔨 Latest commit a0e6086
🔍 Latest deploy log https://app.netlify.com/sites/k8s-kwok/deploys/64589c727d9c9100080f0da4

@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels May 7, 2023
@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels May 7, 2023
@wzshiming wzshiming force-pushed the feat/kind-podman branch 13 times, most recently from d662a8f to 3293196 Compare May 7, 2023 11:13
@k8s-ci-robot k8s-ci-robot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels May 7, 2023
@wzshiming wzshiming force-pushed the feat/kind-podman branch 4 times, most recently from 07c1d39 to 89adcf7 Compare May 7, 2023 11:31
@wzshiming wzshiming force-pushed the feat/kind-podman branch 22 times, most recently from dd55848 to e5ad52f Compare May 8, 2023 03:15
@wzshiming wzshiming changed the title [kwokctl] Support kind with podman [kwokctl] Support kind-podman as kwoctkl runtime May 8, 2023
@wzshiming wzshiming changed the title [kwokctl] Support kind-podman as kwoctkl runtime [kwokctl] Add kind-podman as the kwoctkl runtime May 8, 2023
@wzshiming wzshiming merged commit d671462 into kubernetes-sigs:main May 8, 2023
28 of 29 checks passed
@wzshiming wzshiming deleted the feat/kind-podman branch May 8, 2023 08:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/feature Categorizes issue or PR as related to a new feature. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[kwokctl] Add kind-podman as the kwoctkl runtime
2 participants