Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add scripts for yamllint #394

Merged
merged 1 commit into from
Mar 21, 2023
Merged

Conversation

Zhuzhenghao
Copy link
Contributor

What type of PR is this?

/kind feature

What this PR does / why we need it:

Add scripts to lint YAML files.

Which issue(s) this PR fixes:

Fixes #268

Special notes for your reviewer:

Does this PR introduce a user-facing change?

NONE

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

@k8s-ci-robot k8s-ci-robot added the kind/feature Categorizes issue or PR as related to a new feature. label Mar 21, 2023
@netlify
Copy link

netlify bot commented Mar 21, 2023

Deploy Preview for k8s-kwok canceled.

Name Link
🔨 Latest commit f73830d
🔍 Latest deploy log https://app.netlify.com/sites/k8s-kwok/deploys/64195e4dfbd4b80008dee8f5

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Mar 21, 2023
@k8s-ci-robot k8s-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Mar 21, 2023
hack/verify-yamllint.sh Outdated Show resolved Hide resolved
hack/verify-yamllint.sh Outdated Show resolved Hide resolved
hack/verify-yamllint.sh Outdated Show resolved Hide resolved
@Zhuzhenghao Zhuzhenghao force-pushed the yamllint branch 2 times, most recently from 1d0b7a3 to b191fbe Compare March 21, 2023 06:34
hack/verify-yamllint.sh Outdated Show resolved Hide resolved
hack/verify-all.sh Outdated Show resolved Hide resolved
hack/verify-yamllint.sh Outdated Show resolved Hide resolved
.yamllint.conf Outdated Show resolved Hide resolved
Copy link
Member

@wzshiming wzshiming left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve
/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 21, 2023
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: wzshiming, Zhuzhenghao

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 21, 2023
@k8s-ci-robot k8s-ci-robot merged commit 64d08be into kubernetes-sigs:main Mar 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/feature Categorizes issue or PR as related to a new feature. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add formatters for .yaml
3 participants