-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix VerbosityZero check panic #5
fix VerbosityZero check panic #5
Conversation
I cannot reproduce the original problem anymore, so let's keep the code as it is. /close |
@pohly: Closed this PR. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
yeah, I agree. |
/reopen |
@yangjunmyfm192085: Reopened this PR. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
f60c7b1
to
dae0ebb
Compare
dae0ebb
to
1076b67
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/cc @pohly
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/approve
Thanks for the persistence with which you tracked this down.
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: pohly, yangjunmyfm192085 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
try to fix #4 (comment)
When Constants of value is defined in different files, there will be cases where it cannot be parsed directly.
it will trigger panic