Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create Test 2 / "local service not impacted" e2e test #16

Open
Tracked by #14
lauralorenz opened this issue Aug 8, 2022 · 15 comments · May be fixed by #53
Open
Tracked by #14

Create Test 2 / "local service not impacted" e2e test #16

lauralorenz opened this issue Aug 8, 2022 · 15 comments · May be fixed by #53
Assignees

Comments

@lauralorenz
Copy link
Contributor

Per the KEP, an e2e test must exist that tests:

Test cluster A local service not impacted by same-name imported service.

We define "not impacted" as:

Not impacted = when you run a Service in cluster A called foo, and you have a ServiceImport for foo, you can still resolve foo.ns.svc.cluster.local and and its IP is different from the ServiceImport IP and when you actually request the local service IPs you get a response back and its the right response (so we have to make the response smart, such as reporting their clusterID)
foo.ns.svc.clusterset.local will sometimes return clusterB
foo.ns.svc.cluster.local will always (always=50 times in a row) return cluster A

Given a setup with two clusters, this test should do the following:

  • Service is in ClusterA, NOT exported
    • can hit it with cluster.local
  • Service is in ClusterB and exported
    • can hit it with clusterset.local, always reports ClusterB
  • Also Export the Service in ClusterA
    • can hit it with clusterset.local, sometimes will say ClusterB, sometimes will say ClusterA
  • Hit it 50 times, if I get at least one from either we good
    • Can still hit it with cluster.local, will ALWAYS say its from clusterA
    • No other services should be responding
      • Relevant because if the SUT happens to have other clusters participating and they get all up in there, we want to report that

See the existing connectivity test for inspiration on setup and potential request and response pods. Notably in this case the response needs to be smart enough to share what cluster it is in.

@k8s-triage-robot
Copy link

The Kubernetes project currently lacks enough contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Mark this issue or PR as fresh with /remove-lifecycle stale
  • Mark this issue or PR as rotten with /lifecycle rotten
  • Close this issue or PR with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Nov 6, 2022
@lauralorenz
Copy link
Contributor Author

/remove-lifecycle stale

@k8s-ci-robot k8s-ci-robot removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Nov 9, 2022
@lauralorenz
Copy link
Contributor Author

/assign lauralorenz
@knee-berts is helping me with this one

@k8s-triage-robot
Copy link

The Kubernetes project currently lacks enough contributors to adequately respond to all issues.

This bot triages un-triaged issues according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Mark this issue as fresh with /remove-lifecycle stale
  • Close this issue with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Feb 15, 2023
@lauralorenz
Copy link
Contributor Author

/remove-lifecycle stale

@k8s-ci-robot k8s-ci-robot removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Mar 6, 2023
@k8s-triage-robot
Copy link

The Kubernetes project currently lacks enough contributors to adequately respond to all issues.

This bot triages un-triaged issues according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Mark this issue as fresh with /remove-lifecycle stale
  • Close this issue with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jun 4, 2023
@k8s-triage-robot
Copy link

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues.

This bot triages un-triaged issues according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Mark this issue as fresh with /remove-lifecycle rotten
  • Close this issue with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle rotten

@k8s-ci-robot k8s-ci-robot added lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Jul 4, 2023
@k8s-triage-robot
Copy link

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs.

This bot triages issues according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Reopen this issue with /reopen
  • Mark this issue as fresh with /remove-lifecycle rotten
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/close not-planned

@k8s-ci-robot
Copy link
Contributor

@k8s-triage-robot: Closing this issue, marking it as "Not Planned".

In response to this:

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs.

This bot triages issues according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Reopen this issue with /reopen
  • Mark this issue as fresh with /remove-lifecycle rotten
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/close not-planned

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot closed this as not planned Won't fix, can't repro, duplicate, stale Jan 19, 2024
@nojnhuh
Copy link
Contributor

nojnhuh commented May 14, 2024

I can take this one!

/reopen
/assign

@k8s-ci-robot
Copy link
Contributor

@nojnhuh: Reopened this issue.

In response to this:

I can take this one!

/reopen
/assign

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@nojnhuh
Copy link
Contributor

nojnhuh commented May 14, 2024

/remove-lifecycle rotten

@k8s-ci-robot k8s-ci-robot removed the lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. label May 14, 2024
@nojnhuh
Copy link
Contributor

nojnhuh commented May 14, 2024

Sorry @lauralorenz didn't catch that you were already assigned to this. Don't mean to step on your toes, but happy to pick this up!

@nojnhuh
Copy link
Contributor

nojnhuh commented May 30, 2024

@lauralorenz Just to clarify since these tests involve setting up DNS, is compiling our own CoreDNS with https://github.com/coredns/multicluster and configuring that for kind the recommended approach? Are there any other steps required to make the clusterset.local domain reachable?

@nojnhuh
Copy link
Contributor

nojnhuh commented May 31, 2024

@lauralorenz Just to clarify since these tests involve setting up DNS, is compiling our own CoreDNS with https://github.com/coredns/multicluster and configuring that for kind the recommended approach? Are there any other steps required to make the clusterset.local domain reachable?

I think I got this working here: #50

@nojnhuh nojnhuh linked a pull request Jun 25, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants