Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update e2e tests to support k8s 1.21+ only, particularly to fix EndpointSlice version errors when using them today #19

Closed
lauralorenz opened this issue Nov 15, 2022 · 6 comments · Fixed by #41
Closed

Update e2e tests to support k8s 1.21+ only, particularly to fix EndpointSlice version errors when using them today #19

lauralorenz opened this issue Nov 15, 2022 · 6 comments · Fixed by #41
Assignees
@lauralorenz @sbdtu5498
Labels
help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines.

Comments

@lauralorenz
Copy link
Contributor

We happen to be observing a breakage in our e2e tests against clusters running above Kubernetes version 1.21. This is because the MCS API is dependent on EndpointSlices and the e2e tests happened to have been written when EndpointSlice was in v1beta1 and implemented as such, but which GA'd to v1 in Kubernetes 1.21.

Per discussion in SIG-MC today 11/15/2022, e2etests have a lower standard of backwards compatibility than vendor implementations might choose, and we are ok with making them work against only the GA version of EndpointSlice, even in their role as conformance tests. Some of the reasons given were because it's been out for longer than a year, that in the purview of MCS API history its been a stable dependency, etc.
@lauralorenz
Copy link
Contributor Author

/help

@k8s-ci-robot
Copy link
Contributor

@lauralorenz:
This request has been marked as needing help from a contributor.

Guidelines

Please ensure that the issue body includes answers to the following questions:

  • Why are we solving this issue?
  • To address this issue, are there any code changes? If there are code changes, what needs to be done in the code and what places can the assignee treat as reference points?
  • Does this issue have zero to low barrier of entry?
  • How can the assignee reach out to you for help?

For more details on the requirements of such an issue, please see here and ensure that they are met.

If this request no longer meets these requirements, the label can be removed
by commenting with the /remove-help command.

In response to this:

/help

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. label Nov 17, 2022
@lauralorenz
Copy link
Contributor Author

/assign lauralorenz
@IshmeetMehta is helping with this one

@lauralorenz
Copy link
Contributor Author

I think this is fixed by #24

@lauralorenz
Copy link
Contributor Author

Can confirm this is fixed by #24, just need to remove the pin on 1.21 in the cluster setup (ie https://github.com/kubernetes-sigs/mcs-api/blob/master/scripts/c1.yaml#L10)

@sbdtu5498
Copy link
Contributor

/assign

@sbdtu5498 sbdtu5498 mentioned this issue Aug 7, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@lauralorenz lauralorenz

@sbdtu5498 sbdtu5498

Labels
help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

removing pin on kind image from v1.21 sbdtu5498/mcs-api
3 participants
@lauralorenz @k8s-ci-robot @sbdtu5498