Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support v1 Discovery EndpointSlices #24

Merged
merged 6 commits into from
Jan 11, 2023

Conversation

skitt
Copy link
Member

@skitt skitt commented Nov 25, 2022

This extends the connectivity test setup to support either v1beta1
Discovery or v1 Discovery.

Signed-off-by: Stephen Kitt skitt@redhat.com

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Nov 25, 2022
@skitt
Copy link
Member Author

skitt commented Nov 25, 2022

Note that this builds on top of #22.

@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Nov 29, 2022
This updates the boilerplate verification script to specify python3,
and takes into account current Go code generation (go:build along with
+build).

Signed-off-by: Stephen Kitt <skitt@redhat.com>
This is currently the oldest supported version, and results in a more
comprehensive go.mod.

Signed-off-by: Stephen Kitt <skitt@redhat.com>
Signed-off-by: Stephen Kitt <skitt@redhat.com>
Signed-off-by: Stephen Kitt <skitt@redhat.com>
Signed-off-by: Stephen Kitt <skitt@redhat.com>
This extends the connectivity test setup to support either v1beta1
Discovery or v1 Discovery.

Signed-off-by: Stephen Kitt <skitt@redhat.com>
@lauralorenz
Copy link
Contributor

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 11, 2023
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dfarrell07, lauralorenz, skitt

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 11, 2023
@k8s-ci-robot k8s-ci-robot merged commit b8e43ca into kubernetes-sigs:master Jan 11, 2023
@skitt skitt deleted the discoveryv1b1 branch January 16, 2023 14:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants