Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

minikube-gui should have a setting page to override the minikube binary #6

Closed
medyagh opened this issue Jan 18, 2023 · 2 comments
Closed

minikube-gui should have a setting page to override the minikube binary #6

medyagh opened this issue Jan 18, 2023 · 2 comments
Labels
good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines.

Comments

@medyagh
Copy link
Contributor

medyagh commented Jan 18, 2023 •
edited
Loading

currently minikube-gui uses whatever binary is in the path based on an order in this PR:
#4

but it would be best if we have a settings page that would let you override/select the exact minikube binary to use (maybe show the version in parentheses

(drop down menu)

  • /usr/loca/bin/minikube (version 1.28.0)
  • /opt/homebrew/bin/minikube (version 1.27.1)
  • ...

or and maybe minikube gui should default to the latest version instead.

Originally posted by @medyagh in #4 (review)
@medyagh medyagh added the good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. label Jan 18, 2023
@medyagh medyagh changed the title looks good to me, best would be if the GUI has its own Settings page (called gui settings) minikube-gui should have a setting page to override the minikube binary Jan 18, 2023
@medyagh medyagh mentioned this issue Jan 19, 2023
Merged
@Sajiyah-Salat
Copy link

Please close this pr if its completed

@spowelljr
Copy link
Member

spowelljr commented Apr 18, 2023 •
edited
Loading

Completed in
#38
#41
#42
#43

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@medyagh @spowelljr @Sajiyah-Salat