add font-awesome icons and re-arrange basic view #7
Conversation
k8s-ci-robot
added
the
cncf-cla: yes
k8s-ci-robot
added
approved
k8s-ci-robot
added
size/M
basicview.cpp
Outdated
| const QString reloadIcon = "\uf021"; | ||
|
|
||
| void BasicView::setFA(QWidget *wid) | ||
| { |
There was a problem hiding this comment.
thats actually what the formmater did for me, it makes the curly brace in next line, when I run
clang-format -i *.cpp *.h
basicview.cpp
Outdated
| } | ||
|
|
||
|
|
||
| static QString getPauseLabel(bool isPaused) | ||
| { | ||
| if (isPaused) { | ||
| return "Unpause"; |
There was a problem hiding this comment.
This is going to change the button to text once it's paused. Will want to make this a icon as well.
There was a problem hiding this comment.
yeah I know unfortunately we dont have icon for it now in FA 5, I am gonna have it as is for now, till we get the FA working
k8s-ci-robot
added
size/L
|
|
yes I created an issue for disccusing redoing the button logics, #6 |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: medyagh, spowelljr The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Before
After
13537652-2bdd9834-0352-4ab0-a7ab-a93f770302ff.png">