Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix unpause button #12

Merged
merged 5 commits into from
Jan 24, 2023
Merged

fix unpause button #12

merged 5 commits into from
Jan 24, 2023

Conversation

medyagh
Copy link
Contributor

@medyagh medyagh commented Jan 23, 2023 •
edited

Screenshot 2023-01-23 at 2 23 26 PM

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. approved Indicates a PR has been approved by an approver from all required OWNERS files. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jan 23, 2023
spowelljr
spowelljr requested changes Jan 23, 2023
View reviewed changes
Copy link
Member

@spowelljr spowelljr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you also update this for advanced view?

src/basicview.cpp Outdated Show resolved Hide resolved
src/basicview.cpp Outdated Show resolved Hide resolved
@medyagh
Copy link
Contributor Author

medyagh commented Jan 23, 2023

Could you also update this for advanced view?

done

@medyagh medyagh mentioned this pull request Jan 23, 2023
Merged
@k8s-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: medyagh, spowelljr

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@spowelljr spowelljr merged commit 6e9db6b into main Jan 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@spowelljr spowelljr spowelljr approved these changes

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@medyagh @k8s-ci-robot @spowelljr