#259 added test for (MTB-PL1-BC-CPI-2) #559
Conversation
k8s-ci-robot
added
the
cncf-cla: yes
k8s-ci-robot
added
the
needs-ok-to-test
|
Hi @phoenixking25. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
k8s-ci-robot
added
the
size/L
|
/ok-to-test |
k8s-ci-robot
added
ok-to-test
|
/assign @realshuting |
|
@JimBugwadia: GitHub didn't allow me to assign the following users: realshuting. Note that only kubernetes-sigs members, repo collaborators and people who have commented on this issue/PR can be assigned. Additionally, issues/PRs can only have 10 assignees at the same time. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/assign @realshuting |
| "time" | ||
|
|
||
| "github.com/onsi/ginkgo" | ||
| configutil "github.com/realshuting/multi-tenancy/benchmarks/e2e/config" |
There was a problem hiding this comment.
There was a problem hiding this comment.
#538
@JimBugwadia sure, to run the tests i had to put the path like this before the given merge, i was just waiting for that merge so my pr dont create conflict
benchmarks/e2e/tests/e2e.go
Outdated
| @@ -11,6 +11,7 @@ import ( | |||
| // test sources | |||
| _ "github.com/realshuting/multi-tenancy/benchmarks/e2e/tests/block_cluster_resources" | |||
| _ "github.com/realshuting/multi-tenancy/benchmarks/e2e/tests/configure_ns_quotas" | |||
| _ "github.com/realshuting/multi-tenancy/benchmarks/e2e/tests/block_multitenant_resources" | |||
| ) | |||
There was a problem hiding this comment.
Can we make these paths relative? Currently these seem to be referring to a forked repo...
There was a problem hiding this comment.
I will push new commit in each pr correcting this ASAP
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: JimBugwadia, phoenixking25 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
There was a problem hiding this comment.
@phoenixking25 - please rebase / fix the the merge conflict for benchmarks/e2e/tests/e2e.go.
done |
…ancy into block-multitenant-resources
|
/lgtm |
k8s-ci-robot
added
lgtm
|
/lgtm |
k8s-ci-robot
removed
lgtm
|
/lgtm |
No description provided.