Skip to content
This repository has been archived by the owner on Jun 26, 2023. It is now read-only.

Added test definition for [MTB-PL3-BC-CPV-1] #659

Merged
merged 3 commits into from
Jun 5, 2020
Merged

Added test definition for [MTB-PL3-BC-CPV-1] #659

merged 3 commits into from
Jun 5, 2020

Conversation

phoenixking25
Copy link
Contributor

/assign @JimBugwadia

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Apr 21, 2020
@k8s-ci-robot
Copy link
Contributor

Hi @phoenixking25. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Apr 21, 2020
@JimBugwadia
Copy link
Contributor

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Apr 27, 2020
JimBugwadia
JimBugwadia suggested changes Apr 27, 2020
View reviewed changes
benchmarks/e2e/tests/create_tenant_crds/README.md Outdated

**Remediation:**

Define a Custom Addmission Controller to validate the CRD manifest file, or use a policy engine such as [OPA/Gatekeeper](https://github.com/open-policy-agent/gatekeeper) or [Kyverno](https://kyverno.io) to validate against the default pattern.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The remediation here should be different, as policy engines will not allow control plane virtualization. The only available solution for this is the Virtual Cluster project so we can propose that.

@phoenixking25 phoenixking25 changed the title added test definition for [MTB-PL3-BC-CPV-1] [WIP] added test definition for [MTB-PL3-BC-CPV-1] Apr 27, 2020
@k8s-ci-robot k8s-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Apr 27, 2020
@phoenixking25 phoenixking25 changed the title [WIP] added test definition for [MTB-PL3-BC-CPV-1] Added test definition for [MTB-PL3-BC-CPV-1] Apr 29, 2020
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Apr 29, 2020
@JimBugwadia
Copy link
Contributor

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Jun 5, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: JimBugwadia, phoenixking25

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 5, 2020
@k8s-ci-robot k8s-ci-robot merged commit c6b9e17 into kubernetes-retired:master Jun 5, 2020
@phoenixking25 phoenixking25 mentioned this pull request Aug 23, 2020
Closed
6 tasks
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@JimBugwadia JimBugwadia JimBugwadia approved these changes

@Fei-Guo Fei-Guo Awaiting requested review from Fei-Guo

@rjbez17 rjbez17 Awaiting requested review from rjbez17

Assignees

@JimBugwadia JimBugwadia

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm Indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@phoenixking25 @k8s-ci-robot @JimBugwadia