Apply suggestions from code review

Co-authored-by: Markus Lehtonen <markus.lehtonen@intel.com>

controllers/nodefeaturediscovery_status.go

@@ -14,14 +14,12 @@ import (
 )
 
 // nodeType is either 'worker' or 'master'
-type nodeType int
+type nfdInstanceType string
 
 const (
-	worker       nodeType = iota
-	master       nodeType
-	nfdNamespace          = "node-feature-discovery-operator"
-	workerName            = "nfd-worker"
-	masterName            = "nfd-master"
+	nfdNamespace                   = "node-feature-discovery-operator"
+	workerInstance nfdInstanceType = "nfd-worker"
+	masterInstance nfdInstanceType = "nfd-master"
 )
 
 const (
@@ -130,15 +128,8 @@ func (r *NodeFeatureDiscoveryReconciler) updateStatus(nfd *nfdv1.NodeFeatureDisc
 
 // updateDegradedCondition is used to mark a given resource as "degraded" so that
 // the reconciler can take steps to rectify the situation.
-func (r *NodeFeatureDiscoveryReconciler) updateDegradedCondition(nfd *nfdv1.NodeFeatureDiscovery, condition string, conditionErr error) (ctrl.Result, error) {
-
-	// It is already assumed that the resource has been degraded, so the first
-	// step is to gather the correct list of conditions.
-	var conditionErrMsg string = "Degraded"
-	if conditionErr != nil {
-		conditionErrMsg = conditionErr.Error()
-	}
-	degradedCondition := r.getDegradedConditions(condition, conditionErrMsg)
+func (r *NodeFeatureDiscoveryReconciler) updateDegradedCondition(nfd *nfdv1.NodeFeatureDiscovery, reason, message string) (ctrl.Result, error) {
+	degradedCondition := r.getDegradedConditions(reason, message)
 	if err := r.updateStatus(nfd, degradedCondition); err != nil {
 		return reconcile.Result{}, err
 	}