Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update release references #159

Merged
merged 1 commit into from
Jun 6, 2022

Conversation

ArangoGutierrez
Copy link
Contributor

Signed-off-by: Carlos Eduardo Arango Gutierrez carangog@redhat.com

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label May 19, 2022
@ArangoGutierrez ArangoGutierrez mentioned this pull request May 19, 2022
31 tasks
@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels May 19, 2022
@ArangoGutierrez
Copy link
Contributor Author

/assign @marquiz

Copy link
Contributor

@marquiz marquiz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You want to update operand_version in config/manager/manager.yaml as well.

Also the references in config/manager/manager.yaml and config/manifests/bases/nfd-operator.clusterserviceversion.yaml(?)

We really should probably have a script under hack/ to do these, I think. Smth similar to prepare-release.sh in nfd or anything

@marquiz
Copy link
Contributor

marquiz commented May 23, 2022

What about config/manifests/bases/nfd-operator.clusterserviceversion.yaml, should(n't) it be updated, too?

@ArangoGutierrez
Copy link
Contributor Author

What about config/manifests/bases/nfd-operator.clusterserviceversion.yaml, should(n't) it be updated, too?

It is

Signed-off-by: Carlos Eduardo Arango Gutierrez <carangog@redhat.com>
Copy link
Contributor

@marquiz marquiz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👌
/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 6, 2022
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ArangoGutierrez, marquiz

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [ArangoGutierrez,marquiz]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ArangoGutierrez
Copy link
Contributor Author

/retest

@ArangoGutierrez
Copy link
Contributor Author

Hello mr Prow....
/woof

@k8s-ci-robot
Copy link
Contributor

@ArangoGutierrez: dog image

In response to this:

Hello mr Prow....
/woof

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ArangoGutierrez
Copy link
Contributor Author

/retest

@ArangoGutierrez
Copy link
Contributor Author

/test pull-node-feature-discovery-operator-verify

@k8s-ci-robot k8s-ci-robot merged commit cb5792b into kubernetes-sigs:release-0.5 Jun 6, 2022
@ArangoGutierrez ArangoGutierrez deleted the r05-docs branch March 13, 2023 10:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants