Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Consider using client-go instead of the unversioned client. #38

Closed
balajismaniam opened this issue Oct 28, 2016 · 1 comment
Closed

Consider using client-go instead of the unversioned client. #38

balajismaniam opened this issue Oct 28, 2016 · 1 comment
Labels
help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. kind/feature Categorizes issue or PR as related to a new feature.
Milestone
v0.1.0

Comments

@balajismaniam
Copy link
Contributor

Right now NFD uses the unversioned client to talk to the K8s cluster. We should consider using the client-go (https://github.com/kubernetes/client-go) instead.
@ConnorDoyle
Copy link
Contributor

+1000

@ConnorDoyle ConnorDoyle added help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. kind/feature Categorizes issue or PR as related to a new feature. labels Oct 29, 2016
@ConnorDoyle ConnorDoyle self-assigned this Nov 12, 2016
@ConnorDoyle ConnorDoyle mentioned this issue Nov 12, 2016
Merged
nfd-merge-bot added a commit that referenced this issue Nov 16, 2016
@nfd-merge-bot
Merge pull request #43 from ConnorDoyle/use-client-go
acdf1f8 
Automatic merge from submit-queue

[WIP] Use out-of-tree k8s go client.

Fixes #38.

Builds and tests pass, but still needs manual testing (since we don't have e2e set up yet.)

This also speeds up the build quite a bit.
@ConnorDoyle ConnorDoyle modified the milestone: v0.1.0 Dec 7, 2016
dagrayvid pushed a commit to dagrayvid/node-feature-discovery that referenced this issue Sep 22, 2021
@openshift-merge-robot
Merge pull request kubernetes-sigs#38 from openshift/zvonkok-patch-5
9a82d4c 
Update system.go
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. kind/feature Categorizes issue or PR as related to a new feature.
Projects
None yet
Milestone
v0.1.0
Development

No branches or pull requests
2 participants
@ConnorDoyle @balajismaniam