Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Built container wrongly describes version as "-dirty". #54

Closed
ConnorDoyle opened this issue Dec 7, 2016 · 1 comment
Closed

Built container wrongly describes version as "-dirty". #54

ConnorDoyle opened this issue Dec 7, 2016 · 1 comment
Labels
help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. kind/bug Categorizes issue or PR as related to a bug.
Milestone
v0.2.0

Comments

@ConnorDoyle
Copy link
Contributor

The .dockerignore file in the repo excludes the demo/ directory from the Docker context during build, which causes git to think there are uncommitted changes in the workspace.
@ConnorDoyle ConnorDoyle added kind/bug Categorizes issue or PR as related to a bug. help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. labels Dec 7, 2016
@ConnorDoyle ConnorDoyle modified the milestone: v0.2.0 Dec 7, 2016
@balajismaniam balajismaniam self-assigned this Dec 9, 2016
@balajismaniam
Copy link
Contributor

The reason we ignore demo directory was the input file size of the benchmarks used in the demo. This was fixed by #19. Just removing demo directory from .dockerignore should be enough to fix this.

@balajismaniam balajismaniam mentioned this issue Dec 9, 2016
Merged
nfd-merge-bot added a commit that referenced this issue Dec 9, 2016
@nfd-merge-bot
Merge pull request #58 from balajismaniam/fix-nfd-version-suffix
0569d22 
Automatic merge from submit-queue

Fix to report the correct version inside container.

Fixes #54. Tested manually.
- Removed demo directory from .dockerignore.
dagrayvid pushed a commit to dagrayvid/node-feature-discovery that referenced this issue Sep 22, 2021
@openshift-merge-robot
Merge pull request kubernetes-sigs#54 from ArangoGutierrez/bz/2000538
0688292 
Bug 2000538: Vendor grpc-health-probe
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. kind/bug Categorizes issue or PR as related to a bug.
Projects
None yet
Milestone
v0.2.0
Development

No branches or pull requests
2 participants
@ConnorDoyle @balajismaniam