Fix to report the correct version inside container. #58
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
the
cncf-cla: yes
|
Not opposed to this fix, but we could also consider injecting the version instead of trying to compute it inside the container? We could look at using |
- Used build args to pass the correct version.
balajismaniam
force-pushed
the
fix-nfd-version-suffix
branch
from
484c24e
to
d527d58
Compare
|
@ConnorDoyle I updated it. PTAL. See output below. root@e6ca80a74e13:/go/src/github.com/kubernetes-incubator/node-feature-discovery# git status
On branch fix-nfd-version-suffix
Changes not staged for commit:
(use "git add/rm <file>..." to update what will be committed)
(use "git checkout -- <file>..." to discard changes in working directory)
deleted: demo/README.md
deleted: demo/docker-images/Dockerfile-CloverLeaf
deleted: demo/docker-images/Dockerfile-PARSEC
deleted: demo/docs/performance-comparison-cloverleaf-norm.png
deleted: demo/docs/performance-comparison-parsec-norm.png
deleted: demo/helper-scripts/aggregate-logs-and-plot.sh
deleted: demo/helper-scripts/box-plot-norm.R
deleted: demo/helper-scripts/box-plot.R
deleted: demo/helper-scripts/clean-up.sh
deleted: demo/helper-scripts/demo-pod-with-discovery.json.parsec.template
deleted: demo/helper-scripts/demo-pod-with-discovery.yaml.cloverleaf.template
deleted: demo/helper-scripts/demo-pod-without-discovery.json.template
deleted: demo/helper-scripts/run-with-discovery.sh
deleted: demo/helper-scripts/run-without-discovery.sh
no changes added to commit (use "git add" and/or "git commit -a")
root@e6ca80a74e13:/go/src/github.com/kubernetes-incubator/node-feature-discovery# /go/bin/node-feature-discovery --version
node-feature-discovery cc335e6
root@e6ca80a74e13:/go/src/github.com/kubernetes-incubator/node-feature-discovery# git describe --tags --dirty --always
cc335e6-dirty |
|
Nice. |
|
/lgtm |
nfd-merge-bot
added
the
lgtm
|
Automatic merge from submit-queue |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #54. Tested manually.