Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

go.mod: Update cpuid to its v2.2.6 release #1453

Merged
merged 1 commit into from
Nov 6, 2023
Merged

go.mod: Update cpuid to its v2.2.6 release #1453

merged 1 commit into from
Nov 6, 2023

Conversation

fidencio
Copy link
Contributor

@fidencio fidencio commented Nov 6, 2023

Let's update the cpuid to v2.2.6 release, released on November 6th 2023, as it brings information about TDX Guests virtualised atop of Hyper-V.

cpuid's changelog:

v2.2.6 (Latest)

What's Changed
* Add Intel apx, avx10, keylocker by @klauspost in #134
* Update README.md by @klauspost in #136
* Detect TDX Guest when it's virtualised using Hyper-V by @fidencio in #138

@k8s-ci-robot k8s-ci-robot added do-not-merge/invalid-commit-message Indicates that a PR should not merge because it has an invalid commit message. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Nov 6, 2023
@netlify Netlify
Copy link

netlify bot commented Nov 6, 2023 •
edited
Loading

✅ Deploy Preview for kubernetes-sigs-nfd ready!

Name Link
🔨 Latest commit 42ad669
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-sigs-nfd/deploys/6549250568c5de00083741f8
😎 Deploy Preview https://deploy-preview-1453--kubernetes-sigs-nfd.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Nov 6, 2023
@k8s-ci-robot
Copy link
Contributor

Hi @fidencio. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Nov 6, 2023
@fidencio
Copy link
Contributor Author

fidencio commented Nov 6, 2023

"invalid commit message", ooi? Why is this happening?

@fidencio
go.mod: Update cpuid to its v2.2.6 release
42ad669 
Let's update the cpuid to v2.2.6 release, released on November 6th 2023,
as it brings information about TDX Guests virtualised atop of Hyper-V.

cpuid's changelog:
```
v2.2.6 (Latest)

What's Changed
* Add Intel apx, avx10, keylocker by klauspost in 134
* Update README.md by klauspost in 136
* Detect TDX Guest when it's virtualised using Hyper-V by fidencio in 138
```

Signed-off-by: Fabiano Fidêncio <fabiano.fidencio@intel.com>
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/invalid-commit-message Indicates that a PR should not merge because it has an invalid commit message. label Nov 6, 2023
marquiz
marquiz approved these changes Nov 6, 2023
View reviewed changes
Copy link
Contributor

@marquiz marquiz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @fidencio. Looks good to go
/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Nov 6, 2023
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: fidencio, marquiz

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 6, 2023
fmuyassarov
fmuyassarov reviewed Nov 6, 2023
View reviewed changes
Copy link
Member

@fmuyassarov fmuyassarov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 6, 2023
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: c402503c3c1ddf0c743485aa2a488d79796d2fb3

@codecov Codecov
Copy link

codecov bot commented Nov 6, 2023

Codecov Report

Merging #1453 (42ad669) into master (536a006) will not change coverage.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1453   +/-   ##
=======================================
  Coverage   30.55%   30.55%           
=======================================
  Files          58       58           
  Lines        7527     7527           
=======================================
  Hits         2300     2300           
  Misses       4978     4978           
  Partials      249      249

@k8s-ci-robot k8s-ci-robot merged commit 7af3c76 into kubernetes-sigs:master Nov 6, 2023
12 checks passed
@marquiz marquiz mentioned this pull request Dec 20, 2023
Closed
24 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fmuyassarov fmuyassarov fmuyassarov left review comments

@marquiz marquiz marquiz approved these changes

@ArangoGutierrez ArangoGutierrez Awaiting requested review from ArangoGutierrez

Assignees

@fmuyassarov fmuyassarov

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@fidencio @k8s-ci-robot @marquiz @fmuyassarov