nfd-worker: add special handling for --sources=all #356
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
the
cncf-cla: yes
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: marquiz The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
approved
marquiz
force-pushed
the
devel/sources-flag
branch
from
6969e7d
to
a17bf0d
Compare
jjacobelli
reviewed
Nov 20, 2020
marquiz
force-pushed
the
devel/sources-flag
branch
from
a17bf0d
to
d9fdcbb
Compare
k8s-ci-robot
added
size/L
|
Rebased and addressed comments from @Ethyling |
|
/assign @Ethyling |
jjacobelli
reviewed
Nov 20, 2020
A new special value 'all' is a shortcut for enabling all feature sources. It should be the only name specified -- if any other names are specified 'all' does not take effect, but, we only enable the listed feature sources. E.g. --sources=all enables all sources, but --sources=all,cpu only enables the cpu source Also, print a warning if unknown sources are specified.
marquiz
force-pushed
the
devel/sources-flag
branch
from
d9fdcbb
to
29cbb24
Compare
k8s-ci-robot
added
size/M
|
/assign @Ethyling |
|
/lgtm |
k8s-ci-robot
added
the
lgtm
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A new special value 'all' is a shortcut for enabling all feature
sources. It should be the only name specified -- if any other names are
specified 'all' does not take effect, but, we only enable the listed
feature sources. E.g.
--sources=all enables all sources, but
--sources=all,cpu only enables the cpu source