-
Notifications
You must be signed in to change notification settings - Fork 237
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix kustomization template to work with cert-manager #710
Conversation
Welcome @dbaker-rh! |
Hi @dbaker-rh. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work @dbaker-rh!
Now that the manual steps of creating the ca cert are eliminated maybe we could even make this a component under deployment/components/
. WDYT?
/ok-to-test
6c66c85
to
5f5bba1
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good 👍 If you could squash this into one commit I think we could merge this
5f5bba1
to
43c77c2
Compare
squished! |
|
43c77c2
to
3e6ae53
Compare
Sorry. I did a before/after diff and missed it. Re-uploaded a commit. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very welcome improvement @dbaker-rh 😊
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dbaker-rh, marquiz The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
A few changes in this PR:
1/ Make use of cert-manager's selfSigned{} to bootstrap the actual CA creation (removes the need for a manual openssl step)
2/ Update grpc_health_check to use TLS (without this, the master pod won't start)
3/ Update the certs to include "localhost" in the SAN list, so grpc_health_check can work
4/ Update docs (and bump cert-manager referenced to 1.6.1)
Note - this is partly in response to #563