Introduce a request counter to the auditor #359
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
release-note
k8s-ci-robot
added
area/artifacts
This was referenced Jul 21, 2021
Closed
tylerferrara
force-pushed
the
counter
branch
2 times, most recently
from
bb0e24a
to
7a2a632
Compare
listx
requested changes
Jul 21, 2021
tylerferrara
commented
Jul 21, 2021
tylerferrara
changed the title
listx
reviewed
Jul 21, 2021
|
Thanks! /lgtm |
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: listx, tylerferrara The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
tylerferrara
pushed a commit
to tylerferrara/k8s-container-image-promoter
that referenced
this pull request
Jul 21, 2021
Introduce a request counter to the auditor
tylerferrara
pushed a commit
to tylerferrara/k8s-container-image-promoter
that referenced
this pull request
Jul 22, 2021
Introduce a request counter to the auditor
tylerferrara
pushed a commit
to tylerferrara/k8s-container-image-promoter
that referenced
this pull request
Jul 22, 2021
Introduce a request counter to the auditor
tylerferrara
pushed a commit
to tylerferrara/k8s-container-image-promoter
that referenced
this pull request
Jul 22, 2021
Introduce a request counter to the auditor
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind feature
What this PR does / why we need it:
This change creates a simple request counter, able to concurrently keep track of all HTTP requests made to GCR. The counter is only enabled when the user passes the
--verboseflag. In the future, this counter will be logged to gain visibility in the network performance of the auditor.Supersedes #356
Which issue(s) this PR fixes:
Partially satisfies #358
Special notes for your reviewer:
The auditor does not yet call
Increment()to add to the counter. This would perpetually increase the value of the counter if enabled. Once the concurrent logger is implemented (part of #358), which resets the counter every 10min, will the auditor callIncrement().Less importantly, this package is made specifically for the auditor, it can just as easily be used for other commands, like
cip run --snapshot.Does this PR introduce a user-facing change?
NONE
cc: @listx @amwat @justaugustus @kubernetes-sigs/release-engineering