Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate kpromo/cip-mm tools/packages into repo #407

Merged
merged 4 commits into from
Aug 31, 2021

Conversation

justaugustus
Copy link
Member

@justaugustus justaugustus commented Aug 31, 2021

What type of PR is this?

/kind cleanup feature

What this PR does / why we need it:

Migrate kpromo/cip-mm tools/packages from k/release at 62b128c2
Unifying tooling in support of automated file promotion: kubernetes/k8s.io#2624
Follow-up to kubernetes/release#2232.

Signed-off-by: Stephen Augustus foo@auggie.dev

Which issue(s) this PR fixes:

Special notes for your reviewer:

Does this PR introduce a user-facing change?

Migrate kpromo/cip-mm tools/packages from k/release at 62b128c2

@justaugustus justaugustus added this to In progress in Release Engineering (k-sigs) via automation Aug 31, 2021
@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. kind/feature Categorizes issue or PR as related to a new feature. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Aug 31, 2021
@k8s-ci-robot k8s-ci-robot added the area/artifacts Issues or PRs related to the hosting of release artifacts for subprojects label Aug 31, 2021
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: justaugustus

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added area/release-eng Issues or PRs related to the Release Engineering subproject sig/release Categorizes an issue or PR as relevant to SIG Release. wg/k8s-infra approved Indicates a PR has been approved by an approver from all required OWNERS files. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Aug 31, 2021
@justaugustus
Copy link
Member Author

(There is a bit of link cleanup to do and some image building cleanup, so leaving this as WIP for the moment.)

Signed-off-by: Stephen Augustus <foo@auggie.dev>
Signed-off-by: Stephen Augustus <foo@auggie.dev>
Signed-off-by: Stephen Augustus <foo@auggie.dev>
Signed-off-by: Stephen Augustus <foo@auggie.dev>
@justaugustus justaugustus changed the title [WIP] Migrate kpromo/cip-mm tools/packages into repo Migrate kpromo/cip-mm tools/packages into repo Aug 31, 2021
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Aug 31, 2021
@justaugustus
Copy link
Member Author

(There is a bit of link cleanup to do and some image building cleanup, so leaving this as WIP for the moment.)

Links are actually all good.
Since this is a large PR already, I'm going to opt to take the image building cleanup as a follow-up.

/assign @ameukam @puerco @saschagrunert @cpanato
cc: @kubernetes-sigs/release-engineering

@puerco
Copy link
Member

puerco commented Aug 31, 2021

OK, I'm really rubber-stamping this as it is a repo migration but I already see some areas where we could SIG-Release-e-fy the code already.
/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 31, 2021
@k8s-ci-robot k8s-ci-robot merged commit e7df91b into kubernetes-sigs:master Aug 31, 2021
Release Engineering (k-sigs) automation moved this from In progress to Done Aug 31, 2021
@justaugustus
Copy link
Member Author

OK, I'm really rubber-stamping this as it is a repo migration but I already see some areas where we could SIG-Release-e-fy the code already.
/lgtm

Absolutely! I'm going to do some follow-up in a bit :)
...just didn't want the diff to be too crazy

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/artifacts Issues or PRs related to the hosting of release artifacts for subprojects area/release-eng Issues or PRs related to the Release Engineering subproject cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. kind/feature Categorizes issue or PR as related to a new feature. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/release Categorizes an issue or PR as relevant to SIG Release. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Development

Successfully merging this pull request may close these issues.

None yet

6 participants