Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate promotion tooling back to CIP repo #2240

Merged
merged 2 commits into from
Sep 10, 2021

Conversation

justaugustus
Copy link
Member

What type of PR is this?

/kind cleanup documentation

What this PR does / why we need it:

ref: kubernetes-sigs/promo-tools#407

Signed-off-by: Stephen Augustus foo@auggie.dev

Which issue(s) this PR fixes:

Special notes for your reviewer:

Does this PR introduce a user-facing change?

Migrate promotion tooling back to CIP repo

Signed-off-by: Stephen Augustus <foo@auggie.dev>
@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. kind/documentation Categorizes issue or PR as related to documentation. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-priority size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Sep 10, 2021
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: justaugustus

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the area/artifacts Issues or PRs related to the hosting of release artifacts for subprojects label Sep 10, 2021
@k8s-ci-robot k8s-ci-robot added area/release-eng Issues or PRs related to the Release Engineering subproject sig/release Categorizes an issue or PR as relevant to SIG Release. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Sep 10, 2021
Signed-off-by: Stephen Augustus <foo@auggie.dev>
@justaugustus justaugustus changed the title [WIP] Migrate promotion tooling back to CIP repo Migrate promotion tooling back to CIP repo Sep 10, 2021
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Sep 10, 2021
@justaugustus
Copy link
Member Author

/assign @ameukam @puerco @saschagrunert @cpanato
cc: @kubernetes/release-engineering

@justaugustus
Copy link
Member Author

(don't retest; API rate limit: https://prow.k8s.io/view/gs/kubernetes-jenkins/pr-logs/pull/release/2240/pull-release-integration-test/1436352065960939520)

time="2021-09-10T15:36:40Z" level=info msg="Found latest origin/release-1.16 commit 18936c8b181de5701fba4f0b958317f9dbdab0a1"
    changelog_test.go:236: 
        	Error Trace:	changelog_test.go:236
        	Error:      	Expected nil, but got: get latest GitHub tags: unable to retrieve GitHub tags: GET https://api.github.com/repos/kubernetes/kubernetes/tags?page=10&per_page=50: 403 API rate limit of 60 still exceeded until 2021-09-10 16:16:55 +0000 UTC, not making remote request. [rate reset in 40m13s]
        	Test:       	TestNewRCRelease
--- FAIL: TestNewRCRelease (10.83s) 

(Similar to #2225.)

@justaugustus
Copy link
Member Author

/test pull-release-integration-test

1 similar comment
@justaugustus
Copy link
Member Author

/test pull-release-integration-test

@ameukam
Copy link
Member

ameukam commented Sep 10, 2021

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 10, 2021
@k8s-ci-robot k8s-ci-robot merged commit 16076da into kubernetes:master Sep 10, 2021
@k8s-ci-robot k8s-ci-robot added this to the v1.23 milestone Sep 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/artifacts Issues or PRs related to the hosting of release artifacts for subprojects area/release-eng Issues or PRs related to the Release Engineering subproject cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. kind/documentation Categorizes issue or PR as related to documentation. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-priority release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/release Categorizes an issue or PR as relevant to SIG Release. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants