-
Notifications
You must be signed in to change notification settings - Fork 90
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Don't embed tekton schema in ProwJob CRD #196
Conversation
The committers listed above are authorized under a signed CLA. |
Welcome @maboehm! |
Hi @maboehm. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
✅ Deploy Preview for k8s-prow ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
awesome @maboehm can you check the CLA? |
Just an additional comment: we dont use the tekton stuff in our setup, so might be worth double checking (but I did check that the fields are in fact preserved, so confidence is high) |
/ok-to-test |
Do we know who's using the Tekton side in production? Could we get their input on this change? I think this is the right direction but I'm not sure if this would cause some hassle for them on upgrade. |
It's been two weeks, should we just move forward? |
I'd say yes. |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: maboehm, matthyx The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
I agree /lgtm |
The CRD has become too large for standard kubernetes / etcd installations. With this change, the CRD generation is instructed to treat all
tektoncd
types as schema-less (while instructing the apiserver to keep unknown fields). This reduces the size down to around 500KBSeems like upstream, tekton is doing something similar, their CRD does not have a schema: https://github.com/tektoncd/pipeline/blob/main/config/300-crds/300-pipelinerun.yaml#L62-L72
I also updated the
admission
component to use strict validation and to be able to handle CREATE requests as well. With this component deployed, you would get at least some level of safety back, even if the response is a bit lacking right now:(I also did not see the admission component installed in https://github.com/kubernetes/test-infra/tree/master/config/prow so not sure who uses it. We dont have it in our env.)
Fixes #181